🔧 chore: fix msteams client typing #89449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #89449 +/- ##
=======================================
Coverage 87.73% 87.73%
=======================================
Files 10161 10161
Lines 573611 573650 +39
Branches 22565 22565
=======================================
+ Hits 503229 503278 +49
+ Misses 69948 69938 -10
Partials 434 434 |
asottile-sentry
approved these changes
Apr 14, 2025
| # MsTeamsClientMixin abstract client does not handle setting the base url or auth token | ||
| class MsTeamsClientMixin: | ||
| # MsTeamsClientABC abstract client does not handle setting the base url or auth token | ||
| class MsTeamsClientABC(ApiClient, ABC): |
There was a problem hiding this comment.
ideally the mixin would be converted to free functions since it's not really sound (and this patch adds a diamond inheritance) -- but this is an improvement at least
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.