ref(py): Consistently use import * in models
#89444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know we're trying to just straight remove these, but let's at least be consistent for now so that mypy understands that these models are available from this module.
github-actions
bot
added
the
Scope: Backend
mjq
approved these changes
Apr 14, 2025
| @@ -104,8 +104,8 @@ | |||
| from .rollbackorganization import * # NOQA | |||
| from .rollbackuser import * # NOQA | |||
| from .rule import * # NOQA | |||
| from .rulefirehistory import RuleFireHistory # NOQA | |||
| from .rulesnooze import RuleSnooze # NOQA | |||
| from .rulefirehistory import * # NOQA | |||
There was a problem hiding this comment.
Even though rulefirehistory only contains RuleFireHistory, would it still make sense to add an explicit __all__ to avoid inadvertently importing something later via this pattern?
There was a problem hiding this comment.
yeah let me follow up there
evanpurkhiser
deleted the
evanpurkhiser/ref-py-consistently-use-import-in-models
branch
billyvg
pushed a commit
that referenced
this pull request
Apr 14, 2025
I know we're trying to just straight remove these, but let's at least be consistent for now so that mypy understands that these models are available from this module. Needed for this simplification #89440
andrewshie-sentry
pushed a commit
that referenced
this pull request
Apr 22, 2025
I know we're trying to just straight remove these, but let's at least be consistent for now so that mypy understands that these models are available from this module. Needed for this simplification #89440
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know we're trying to just straight remove these, but let's at least be
consistent for now so that mypy understands that these models are
available from this module.
Needed for this simplification #89440