feat(explore): Turn explore modes into tabs #89437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a tab style UI for switching to/from aggregates mode. It's a bit of a hack to avoid changing the underlying data model as this is temporary as we figure out next steps.
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #89437 +/- ##
==========================================
- Coverage 87.73% 82.96% -4.78%
==========================================
Files 10158 10161 +3
Lines 573544 573456 -88
Branches 22565 22554 -11
==========================================
- Hits 503188 475745 -27443
- Misses 69922 97112 +27190
- Partials 434 599 +165 |
…turn-explore-modes-into-tabs
narsaynorath
approved these changes
Apr 14, 2025
| <ToolbarVisualize equationSupport={extras?.includes('equations')} /> | ||
| {mode === Mode.AGGREGATE && <ToolbarGroupBy />} | ||
| {(extras?.includes('tabs') || mode === Mode.AGGREGATE) && <ToolbarGroupBy />} |
There was a problem hiding this comment.
I noticed this field does nothing in this PR until you switch to aggregate mode in the tabs. I assume this is because you mentioned wanting to put in a mini aggregate table below the chart, but wanted to call it out in case that wasn't the intention of this change.
There was a problem hiding this comment.
I was asked to make sure this change was behind a feature flag so we can test it prior to releasing it. This line line is so that if the tabs ui is not enabled, we fall back to the current behaviour of only showing the group by toolbar in aggregate mode.
billyvg
pushed a commit
that referenced
this pull request
Apr 14, 2025
This introduces a tab style UI for switching to/from aggregates mode. It's a bit of a hack to avoid changing the underlying data model as this is temporary as we figure out next steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a tab style UI for switching to/from aggregates mode. It's a bit of a hack to avoid changing the underlying data model as this is temporary as we figure out next steps.