fix(issues): Escape status tag on search #89434
Merged
+62
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tag keys that conflict with our issue keys must be escaped fixes #89369
scttcper
commented
Apr 11, 2025
| @@ -1993,6 +1999,7 @@ export const ISSUE_EVENT_FIELDS_THAT_MAY_CONFLICT_WITH_TAGS: Set<FieldKey> = new | |||
| FieldKey.STACK_MODULE, | |||
| FieldKey.STACK_PACKAGE, | |||
| FieldKey.STACK_STACK_LEVEL, | |||
| FieldKey.STATUS, | |||
There was a problem hiding this comment.
@malwilley i wasn't totally sure about this change and how these are used already
There was a problem hiding this comment.
Yeah this is exactly what this was set was meant to solve so it belongs here
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #89434 +/- ##
==========================================
- Coverage 87.73% 87.73% -0.01%
==========================================
Files 10159 10159
Lines 573756 573750 -6
Branches 22555 22552 -3
==========================================
- Hits 503383 503377 -6
Misses 69939 69939
Partials 434 434 |
malwilley
reviewed
Apr 14, 2025
| /** | ||
| * If a tag conflicts with a reserved keyword, change it to `tags[key]:value` | ||
| */ | ||
| export function escapeIssueTagKey(key: string) { |
There was a problem hiding this comment.
We are doing this same thing in useFetchIssueTags.tsx, can you use this function there as well?
malwilley
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag keys that conflict with our issue keys must be escaped
fixes #89369