fix(explore): Stop Heat Map drag-to-zoom writing duplicate history entries#119336
Merged
gggritso merged 1 commit intoJul 10, 2026
Conversation
…tries Drag-to-zoom on a Heat Map widget writes the new `value` filter into the `metric` URL param directly. The row's search query builder then re-derives that same query from the URL and echoes it back through onChange -> handleSearch -> setQueries, which pushed a second, redundant history entry. That extra entry broke browser back/forward navigation between zoom states. Guard the provider's setQueries navigation with the shared navigateIfQueryChanged helper so the echo becomes a no-op when the query is unchanged, matching how the spans and logs query-param providers already behave. Fixes DAIN-1774 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit ea929fc. Configure here.
nikkikapadia
approved these changes
Jul 9, 2026
JoshuaKGoldberg
approved these changes
Jul 9, 2026
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
Member
There was a problem hiding this comment.
I wonder if we should have like a lint rule or agent sweep about this? ✅
gggritso
deleted the
georgegritsouk/dain-1774-heat-map-zoom-actions-dont-populate-browser-history
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard the metrics query-param provider's
setQueriesnavigation with the sharednavigateIfQueryChangedhelper so drag-to-zoom on a Heat Map widget no longer writes duplicate browser-history entries. Heat Maps hit a slightly different path from time series zoom actions because a Heat Map zoom also updates the query, so this change check is needed.Closes DAIN-1774