fix(dashboards): unify timeseries loading and empty state#119335
Merged
nikkikapadia merged 1 commit intoJul 10, 2026
Merged
Conversation
Comment on lines
467
to
+468
| if (loading || !heatmapResults) { | ||
| return <LoadingPlaceholder />; | ||
| return <HeatMapWidgetVisualization.LoadingPlaceholder />; |
Contributor
There was a problem hiding this comment.
Bug: The WidgetLoadingPanel for heatmaps lacks a positioned parent (position: relative) during reloads, causing the loading indicator to be displayed incorrectly outside the chart area.
Severity: MEDIUM
Suggested Fix
Add position: relative; to the ChartWrapper styled-component. This will establish a positioning context for the absolutely positioned WidgetLoadingPanel, ensuring it is correctly constrained within the chart's boundaries during loading states.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: static/app/views/dashboards/widgetCard/chart.tsx#L467-L468
Potential issue: When a heatmap widget reloads data, the `HeatmapSeriesComponent`
renders a `WidgetLoadingPanel`. This panel uses `position: absolute` styling for its
layout. However, it is rendered inside a `ChartWrapper` component that lacks a
`position: relative` (or similar) style property. Because an absolutely positioned
element is positioned relative to its nearest positioned ancestor, the loading panel
will not be constrained to the chart's area. This results in the loading indicator being
displayed incorrectly, potentially overlaying other UI elements outside of the widget's
boundaries.
Did we get this right? 👍 / 👎 to inform future reviews.
Member
Author
There was a problem hiding this comment.
hm im not seeing this issue visually so i think it's fine? let me know if yall are seeing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aligned the heatmap loading state with the timeseries loading state (aka just the spinner and no loading placeholder shadow) and the empty state with the state of all the other widgets.
ALSO good to note that all non-timeseries widgets have that loading screen; wondering if we want to change them all just to unify the UI.
but anyways this is what it looks like: