feat(grouping): Add Salesforce record ID parameterization#107761
Draft
feat(grouping): Add Salesforce record ID parameterization#107761
Conversation
Parameterize 15 and 18 character Salesforce record IDs so that messages differing only by record ID get grouped together.
github-actions
bot
added
the
Scope: Backend
lobsterkatie
reviewed
Feb 6, 2026
Member
lobsterkatie
left a comment
lobsterkatie
left a comment
There was a problem hiding this comment.
This in principle looks fine, but what do we think are the chances of false positives here?
Comment on lines
+79
to
+84
| ("salesforce_id - 15 char", "006M000002Tks8Z", "<salesforce_id>"), | ||
| ( | ||
| "salesforce_id - in message", | ||
| "Failed to update 006M000002Tks8Z record", | ||
| "Failed to update <salesforce_id> record", | ||
| ), |
Member
There was a problem hiding this comment.
Same comment here as on the previous PR - this test isn't necessary.
Comment on lines
+85
to
+86
| ("salesforce_id - not pure alpha", "troubleshooters", "troubleshooters"), | ||
| ("salesforce_id - not pure digits 15", "123456789012345", "<int>"), |
Member
There was a problem hiding this comment.
Ummm... am I missing something? In what way are these (respectively) not purely letters and purely numbers?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
salesforce_idparameterization regex that matches 15 and 18 character Salesforce record IDs containing both letters and digitshexpattern to avoid partial matches on 18-char IDs(?!0[xX])to avoid matching hex-prefixed valuesTest plan
pytest -svv --reuse-db tests/sentry/grouping/test_parameterization.py— 204 passed