Skip to content

chore(aci): unhook conditions from rules code#107754

Merged
mifu67 merged 2 commits intomasterfrom
mifu67/aci/decouple-age-utils
Feb 6, 2026
Merged

chore(aci): unhook conditions from rules code#107754
mifu67 merged 2 commits intomasterfrom
mifu67/aci/decouple-age-utils

Conversation

@mifu67
Copy link
Contributor

@mifu67 mifu67 commented Feb 6, 2026

For easier deletion later, the conditions should not rely on utils from the rules directory.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 6, 2026
@mifu67 mifu67 marked this pull request as ready for review February 6, 2026 18:00
@mifu67 mifu67 requested a review from a team as a code owner February 6, 2026 18:00
from enum import StrEnum


class ModelAgeType(StrEnum):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this one for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used by Rules code but not conditions. Going to delete; thanks for the catch!

@mifu67 mifu67 requested a review from ceorourke February 6, 2026 18:17
@mifu67 mifu67 merged commit 3fe94ff into master Feb 6, 2026
72 checks passed
@mifu67 mifu67 deleted the mifu67/aci/decouple-age-utils branch February 6, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants