Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sentry/users/models/user_option.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def unset_value(self, user: User, project: Project, key: str) -> None:
"""
This isn't implemented for user-organization scoped options yet, because it hasn't been needed.
"""
self.filter(user=user, project=project, key=key).delete()
self.filter(user=user, project_id=project.id, key=key).delete()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this preferred?


if not hasattr(self, "_metadata"):
return
Expand Down
16 changes: 16 additions & 0 deletions tests/sentry/users/models/test_user_option.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
from sentry.testutils.cases import TestCase
from sentry.testutils.silo import control_silo_test
from sentry.users.models.user_option import UserOption


@control_silo_test
class UserOptionManagerTest(TestCase):
def test_unset_value(self) -> None:
project = self.create_project()
UserOption.objects.set_value(self.user, "foo", "bar", project=project)
assert UserOption.objects.filter(user=self.user, project_id=project.id, key="foo").exists()

UserOption.objects.unset_value(self.user, project, "foo")
assert not UserOption.objects.filter(
user=self.user, project_id=project.id, key="foo"
).exists()
Loading