Skip to content

fix(debug-files): Extract query param to avoid passing None to ORM filter#107740

Merged
JoshFerge merged 3 commits intomasterfrom
jferg/fix-debug-files-none-guard
Feb 6, 2026
Merged

fix(debug-files): Extract query param to avoid passing None to ORM filter#107740
JoshFerge merged 3 commits intomasterfrom
jferg/fix-debug-files-none-guard

Conversation

@JoshFerge
Copy link
Member

Summary

Found during mypy / django-stubs upgrade in #107710.

Extracts request.GET.get("id") into a local variable so the narrowed type is used in the .filter(id=...) call, avoiding passing a potentially None value to the ORM lookup.

Test plan

  • Pre-commit hooks pass

…lter

Found during mypy / django-stubs upgrade in #107710.
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 5, 2026
@JoshFerge JoshFerge marked this pull request as ready for review February 5, 2026 23:56
@JoshFerge JoshFerge requested a review from a team as a code owner February 5, 2026 23:56
@JoshFerge JoshFerge requested a review from a team February 5, 2026 23:59
@JoshFerge JoshFerge merged commit 411f448 into master Feb 6, 2026
72 checks passed
@JoshFerge JoshFerge deleted the jferg/fix-debug-files-none-guard branch February 6, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants