feat: Add third party plugins to the samples #2289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It is a pain to showcase or troubleshoot the SDK's capabilities to integrate with those plugins when our own samples are the default, empty Unity 2019 project.
Context
The Sentry SDK is rarely going to be the only plugin in use and will have to integrate with some others. I.e. in Sentaur Survivors we're using DOTween and also based on conversations I had, Cysharp UniTask is wildly popular.
But we don't have any samples or snippets anywhere. I.e. getsentry/sentry-docs#14666, the resolved symbolication issues in combination with Cysharp first had to be written and then tested and will get lost again otherwise.
Proposal
We can have an additional scene where we put all those third party samples. We keep this minimally intrusive with the
ThirdPartyDefineSetup.cs. We check what packages are available and enable/disable snippets based on what's installed.Future
Other plugins that come to mind are