Add full command to extras

[ostrolucky]

Fixes #351

[Jean85]

As said in the related issue, it can't be implemented like this, as a default behavior.

[Jean85]

@ste93cry do you think we should recover this into the 4.0 release? Take a look at the discussion in #351 too.

[ste93cry]

I'm generally favourable to adding logging of the command. Regarding the sanitization, As it's a full string I don't think that Sentry can hide or detect specific portions of it so that values of certain command arguments or options will be hidden... I wonder anyway why someone would pass sensitive data as an argument or option, since it would be visible in the CLI as much as in any log system. Bonus question: I'm really doubtful about whether the command should be logged in the extra context or as a breadcrumb

[ostrolucky]

According link in linked issue, laravel also passes whole thing as string, so I don't believe this is an issue.

As for breadcrumbs, in my pov breadcrumbs are something which happens in sequence, like a log. I think command name does not quite fit in that definition, similarly like request url and so on. Especially when command name already is a tag instead of bread crumb and I'm implementing now just logging of full command name - but I deemed full command name being too unique for being a tag, hence second best was extra.

[ste93cry]

As for breadcrumbs, in my pov breadcrumbs are something which happens in sequence, like a log. I think command name does not quite fit in that definition, similarly like request url and so on

True, but in Symfony the concept of subrequest exists as it exists the concept of a command started and running within another. I would say that logging as bredcrumbs both the start of a request and of a command would be useful. Anyway, I agree that at the moment logging the full command in the extras is enough

I deemed full command name being too unique for being a tag

Absolutely agree with this claim

[Jean85]

LGTM 👍 but please add a changelog entry

[Jean85]

Build should be fixed by #480, but there are conflicts now.

[ostrolucky]

rebased