Skip to content

ci: bump actions, move to rustsec/audit-check #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 16, 2025
Merged

Conversation

lcian
Copy link
Member

@lcian lcian commented May 12, 2025

  • bump actions/checkout to v4
  • bumpcodecov/codecov-action to v5 and pass secrets.CODECOV_TOKEN
  • move from actions-rs/audit-check@v1 to rustsec/audit-check@v2 (pinned) which is more or less maintained

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.30%. Comparing base (605d36d) to head (d2f6054).
Report is 62 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
+ Coverage   72.79%   73.30%   +0.51%     
==========================================
  Files          66       62       -4     
  Lines        7804     7272     -532     
==========================================
- Hits         5681     5331     -350     
+ Misses       2123     1941     -182     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lcian lcian changed the title [Do not merge] CI updates ci: bump actions, move to rustsec/audit-check May 12, 2025
@lcian lcian enabled auto-merge (squash) May 12, 2025 15:46
@lcian lcian disabled auto-merge May 12, 2025 15:48
@lcian
Copy link
Member Author

lcian commented May 12, 2025

Seems like tests are getting stuck on Windows.

@viglia
Copy link
Contributor

viglia commented May 13, 2025

Seems like tests are getting stuck on Windows.

@lcian seems like a transient error. I was able to run the Windows job fine.

@lcian
Copy link
Member Author

lcian commented May 13, 2025

Seems like tests are getting stuck on Windows.

@lcian seems like a transient error. I was able to run the Windows job fine.

@viglia
We've had a similar issue also in this PR #779
Windows CI would get stuck when putting more than one test in a single file, had to split them.
So it makes me suspicious that there is some underlying concurrency issue that for some reason happens only on Windows when running the tests.
There's also this #786 which I'm still looking into, could be related.

@lcian
Copy link
Member Author

lcian commented May 16, 2025

Probably just a flake, the issue I linked was not valid and anyway the CI changes have nothing to do this, merging.

@lcian lcian merged commit 7dd572b into master May 16, 2025
26 of 27 checks passed
@lcian lcian deleted the lcian/ci-updates branch May 16, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants