fix(tracing): wrap error with synthetic mechanism only if attaching stacktrace #755
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this change, we wrap an
Errorcaptured with e.g.tracing::errorwith the synthetic mechanism fortracingonly if we effectively have a stack trace to be reported in the error, i.e. featurebacktraceis enabled andattach_stacktraceis enabled.Without this change, using
tracing::error!(error = <err>, <message>)without thebacktracefeature enabled would result in Sentry issues with<unknown>as title, as shown in #723 (comment).Closes #723
Example
Before
After
bandcwill now be grouped under a single issue. This makes sense as they are carrying an equivalentError. In absence of stack frames, we cannot distinguish between the two.bwill still include the additional message, themechanism: tracingindicator and theRust Tracing Context.While
cwill not include this extra info as usual.