feat: introduce release-health feature
#749
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepperoni505
changed the title
release-health featurerelease-health feature
pepperoni505
force-pushed
the
release-health-feature-flag
branch
from
ebfd2ad to
32bc709
Compare
lcian
approved these changes
Mar 20, 2025
There was a problem hiding this comment.
Looks good to me, thanks.
I have tried making sentry-core/src/session.rs into a mod to have just a single #[cfg(feature = "release-health")] there, but that way you would need to add it to other places in sentry-core. I prefer having it appear more often in session.rs itself rather than propagating to other files
Swatinem
approved these changes
Mar 20, 2025
| let session_flusher = RwLock::new(Some(SessionFlusher::new( | ||
| transport.clone(), | ||
| self.options.session_mode, | ||
| ))); | ||
| #[cfg(not(feature = "release-health"))] | ||
| let session_flusher = RwLock::new(None); |
There was a problem hiding this comment.
it might be a bit more work, but avoiding the Client.session_flusher field altogether would be slightly more efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #748 by introducing a new feature enabled by default named
release-health