Skip to content

Conversation

sl0thentr0py
Copy link
Member

Issues

Copy link

linear bot commented Oct 9, 2025

@sl0thentr0py sl0thentr0py force-pushed the neel/config-profile-freq branch from 5591a9e to 9209988 Compare October 9, 2025 15:45
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.20%. Comparing base (3de3190) to head (4c92546).

Additional details and impacted files
@@           Coverage Diff            @@
##           6.0-dev    #2745   +/-   ##
========================================
  Coverage    97.20%   97.20%           
========================================
  Files          130      130           
  Lines         5217     5221    +4     
========================================
+ Hits          5071     5075    +4     
  Misses         146      146           
Components Coverage Δ
sentry-ruby 97.49% <100.00%> (+<0.01%) ⬆️
sentry-rails 96.74% <ø> (ø)
sentry-sidekiq 95.05% <ø> (ø)
sentry-resque 94.44% <ø> (ø)
sentry-delayed_job 94.68% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/configuration.rb 98.12% <100.00%> (+0.01%) ⬆️
sentry-ruby/lib/sentry/profiler.rb 97.11% <100.00%> (ø)
sentry-ruby/lib/sentry/vernier/profiler.rb 98.59% <100.00%> (+0.02%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sl0thentr0py sl0thentr0py force-pushed the neel/config-profile-freq branch from 9209988 to 6c061b5 Compare October 9, 2025 16:03
@sl0thentr0py sl0thentr0py marked this pull request as ready for review October 9, 2025 16:04
@sl0thentr0py sl0thentr0py requested a review from solnic October 9, 2025 16:04
cursor[bot]

This comment was marked as outdated.

@sl0thentr0py sl0thentr0py force-pushed the neel/config-profile-freq branch 2 times, most recently from e3fd2a5 to 2479cb5 Compare October 9, 2025 17:23
@nateberkopec
Copy link
Contributor

This is a major change to the (unconfigured) sampling interval for Vernier, right?

@sl0thentr0py
Copy link
Member Author

correct, this will go on the 6.0 major, will call it out more explicitly in the changelog

@sl0thentr0py sl0thentr0py force-pushed the neel/config-profile-freq branch from 2479cb5 to 4c92546 Compare October 10, 2025 11:10
Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll do some testing to see the impact on the vernier side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants