ref: Move options to wrapper #5340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahsmartin
requested review from
alwx,
antonis and
lucas-zimerman
as code owners
noahsmartin
force-pushed
the
optionsWrapper
branch
from
8996987 to
fa011eb
Compare
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9f211e3 | 451.50 ms | 500.00 ms | 48.50 ms |
| 083f560+dirty | 358.21 ms | 382.00 ms | 23.79 ms |
| c1573b3 | 400.85 ms | 411.82 ms | 10.97 ms |
| df83aad+dirty | 420.87 ms | 434.98 ms | 14.11 ms |
| 000da7a | 454.46 ms | 445.00 ms | -9.46 ms |
| d1fd647+dirty | 413.02 ms | 459.72 ms | 46.70 ms |
| 170d5ea+dirty | 407.92 ms | 422.49 ms | 14.57 ms |
| 5526494 | 440.84 ms | 448.36 ms | 7.52 ms |
| 2b89ce9 | 413.69 ms | 442.58 ms | 28.89 ms |
| 7091004+dirty | 416.11 ms | 423.90 ms | 7.79 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 9f211e3 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 083f560+dirty | 17.75 MiB | 19.70 MiB | 1.96 MiB |
| c1573b3 | 17.75 MiB | 20.15 MiB | 2.41 MiB |
| df83aad+dirty | 43.75 MiB | 47.99 MiB | 4.24 MiB |
| 000da7a | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| d1fd647+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 170d5ea+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 5526494 | 17.75 MiB | 19.68 MiB | 1.93 MiB |
| 2b89ce9 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| 7091004+dirty | 43.75 MiB | 47.99 MiB | 4.23 MiB |
Previous results on branch: optionsWrapper
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 97f46b4+dirty | 358.53 ms | 396.34 ms | 37.81 ms |
| 57a9351+dirty | 484.00 ms | 508.66 ms | 24.66 ms |
| c41e098+dirty | 413.60 ms | 431.94 ms | 18.34 ms |
| ddebfd3+dirty | 506.23 ms | 541.62 ms | 35.39 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 97f46b4+dirty | 43.75 MiB | 47.99 MiB | 4.24 MiB |
| 57a9351+dirty | 43.75 MiB | 47.99 MiB | 4.24 MiB |
| c41e098+dirty | 43.75 MiB | 47.99 MiB | 4.24 MiB |
| ddebfd3+dirty | 43.75 MiB | 47.99 MiB | 4.24 MiB |
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2104bb9+dirty | 313.00 ms | 309.76 ms | -3.24 ms |
| 785ffb1+dirty | 380.65 ms | 451.83 ms | 71.18 ms |
| 88890fe+dirty | 328.30 ms | 319.85 ms | -8.45 ms |
| 46bd012+dirty | 333.76 ms | 359.24 ms | 25.48 ms |
| 90afdd3+dirty | 367.79 ms | 404.84 ms | 37.05 ms |
| 1226664+dirty | 377.65 ms | 453.94 ms | 76.29 ms |
| f234eb4+dirty | 313.23 ms | 333.31 ms | 20.08 ms |
| 2adbd1e+dirty | 366.13 ms | 419.49 ms | 53.36 ms |
| c1573b3+dirty | 355.65 ms | 448.82 ms | 93.17 ms |
| 3bd3f0d+dirty | 334.38 ms | 402.19 ms | 67.81 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2104bb9+dirty | 7.15 MiB | 8.46 MiB | 1.30 MiB |
| 785ffb1+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 88890fe+dirty | 7.15 MiB | 8.44 MiB | 1.28 MiB |
| 46bd012+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 90afdd3+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 1226664+dirty | 7.15 MiB | 8.46 MiB | 1.30 MiB |
| f234eb4+dirty | 7.15 MiB | 8.46 MiB | 1.30 MiB |
| 2adbd1e+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| c1573b3+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 3bd3f0d+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
Previous results on branch: optionsWrapper
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 97f46b4+dirty | 408.42 ms | 465.43 ms | 57.01 ms |
| 57a9351+dirty | 367.12 ms | 383.78 ms | 16.65 ms |
| c41e098+dirty | 477.74 ms | 523.78 ms | 46.04 ms |
| ddebfd3+dirty | 413.23 ms | 446.22 ms | 33.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 97f46b4+dirty | 43.94 MiB | 48.82 MiB | 4.88 MiB |
| 57a9351+dirty | 43.94 MiB | 48.82 MiB | 4.88 MiB |
| c41e098+dirty | 43.94 MiB | 48.82 MiB | 4.88 MiB |
| ddebfd3+dirty | 43.94 MiB | 48.82 MiB | 4.88 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7be1f99+dirty | 1222.43 ms | 1217.15 ms | -5.28 ms |
| 7091004+dirty | 1219.11 ms | 1225.98 ms | 6.87 ms |
| eb07ba3+dirty | 1214.49 ms | 1221.59 ms | 7.10 ms |
| 8490686+dirty | 1227.32 ms | 1240.82 ms | 13.50 ms |
| 955f2eb+dirty | 1225.78 ms | 1239.27 ms | 13.49 ms |
| 000da7a+dirty | 1204.50 ms | 1218.94 ms | 14.44 ms |
| 9f211e3+dirty | 1215.38 ms | 1218.15 ms | 2.77 ms |
| 6479fd5+dirty | 1207.80 ms | 1215.12 ms | 7.32 ms |
| 46bd012+dirty | 1231.78 ms | 1212.30 ms | -19.47 ms |
| 3e0a5f9+dirty | 1233.65 ms | 1239.10 ms | 5.45 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7be1f99+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 7091004+dirty | 3.41 MiB | 4.57 MiB | 1.16 MiB |
| eb07ba3+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 8490686+dirty | 3.19 MiB | 4.56 MiB | 1.38 MiB |
| 955f2eb+dirty | 3.19 MiB | 4.55 MiB | 1.36 MiB |
| 000da7a+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 9f211e3+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| 6479fd5+dirty | 3.19 MiB | 4.53 MiB | 1.35 MiB |
| 46bd012+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 3e0a5f9+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
Previous results on branch: optionsWrapper
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 57a9351+dirty | 1229.15 ms | 1227.35 ms | -1.80 ms |
| 97f46b4+dirty | 1217.84 ms | 1260.30 ms | 42.45 ms |
| c41e098+dirty | 1217.13 ms | 1215.91 ms | -1.23 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 57a9351+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 97f46b4+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| c41e098+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7be1f99+dirty | 1226.69 ms | 1217.76 ms | -8.93 ms |
| 7091004+dirty | 1215.54 ms | 1215.58 ms | 0.04 ms |
| eb07ba3+dirty | 1222.46 ms | 1220.37 ms | -2.08 ms |
| 8490686+dirty | 1227.84 ms | 1228.91 ms | 1.08 ms |
| 955f2eb+dirty | 1235.06 ms | 1253.88 ms | 18.81 ms |
| 000da7a+dirty | 1214.31 ms | 1221.91 ms | 7.61 ms |
| 9f211e3+dirty | 1218.80 ms | 1233.88 ms | 15.08 ms |
| 6479fd5+dirty | 1228.48 ms | 1231.32 ms | 2.84 ms |
| 46bd012+dirty | 1220.49 ms | 1226.89 ms | 6.40 ms |
| 3e0a5f9+dirty | 1226.94 ms | 1230.02 ms | 3.08 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7be1f99+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 7091004+dirty | 3.41 MiB | 4.57 MiB | 1.16 MiB |
| eb07ba3+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 8490686+dirty | 2.63 MiB | 4.00 MiB | 1.36 MiB |
| 955f2eb+dirty | 2.63 MiB | 3.98 MiB | 1.35 MiB |
| 000da7a+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 9f211e3+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| 6479fd5+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
| 46bd012+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 3e0a5f9+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
Previous results on branch: optionsWrapper
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 57a9351+dirty | 1204.91 ms | 1202.81 ms | -2.10 ms |
| 97f46b4+dirty | 1193.82 ms | 1196.24 ms | 2.43 ms |
| c41e098+dirty | 1223.14 ms | 1204.67 ms | -18.46 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 57a9351+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 97f46b4+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| c41e098+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
Collaborator
|
@sentry review |
noahsmartin
force-pushed
the
optionsWrapper
branch
from
fa011eb to
4840e63
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
noahsmartin
force-pushed
the
optionsWrapper
branch
2 times, most recently
from
21f6a8f to
b497819
Compare
noahsmartin
force-pushed
the
optionsWrapper
branch
from
b497819 to
ba58d45
Compare
antonis
reviewed
Nov 7, 2025
packages/core/RNSentryCocoaTester/RNSentryCocoaTester.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
antonis
reviewed
Nov 7, 2025
packages/core/RNSentryCocoaTester/RNSentryCocoaTester.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
antonis
approved these changes
Nov 7, 2025
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thanks again for keeping the RN SDK in sync Noah 🙇
…j/project.pbxproj Co-authored-by: Antonis Lilis <[email protected]>
…j/project.pbxproj Co-authored-by: Antonis Lilis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move code that uses SentryOptions into the .m file so that it can use
@import#skip-changelog