feat(aiohttp): Apply data_collection filtering to URL query strings#6833
Open
ericapisani wants to merge 1 commit into
Open
feat(aiohttp): Apply data_collection filtering to URL query strings#6833ericapisani wants to merge 1 commit into
ericapisani wants to merge 1 commit into
Conversation
Use the new data_collection settings to filter url.query and related span attributes for both the aiohttp server and client integrations, falling back to should_send_default_pii() when data_collection is not configured. Refs PY-2583 Refs #6743
ericapisani
marked this pull request as ready for review
July 16, 2026 18:04
Contributor
Codecov Results 📊✅ 93548 passed | ⏭️ 6302 skipped | Total: 99850 | Pass Rate: 93.69% | Execution Time: 328m 46s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 92.31%. Project has 2457 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.68% 89.81% +0.13%
==========================================
Files 193 193 —
Lines 24004 24105 +101
Branches 8340 8424 +84
==========================================
+ Hits 21526 21648 +122
- Misses 2478 2457 -21
- Partials 1387 1381 -6Generated by Codecov Action |
sentrivana
approved these changes
Jul 22, 2026
| url_attributes = {} | ||
| if should_send_default_pii(): | ||
| if has_data_collection_enabled(client.options): | ||
| url_attributes["url.full"] = "%s://%s%s" % ( |
Contributor
There was a problem hiding this comment.
I know this is just copied from the should_send_default_pii branch, but I've just realized it's wrong: url.full should contain the query and it doesn't.
Probably makes more sense to fix this afterwards, when this stack has been merged. I'll make an issue for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the new data_collection settings to filter url.query and related
span attributes for both the aiohttp server and client integrations,
falling back to should_send_default_pii() when data_collection is not
configured.
Refs #6743
Refs #6743