-
Notifications
You must be signed in to change notification settings - Fork 578
feat(langchain): Set system instruction attribute #5357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexander-alderman-webb
merged 6 commits into
master
from
webb/langchain-ai-prompt-message
Jan 23, 2026
+90
−10
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1c87221
feat(langchain): Set system instruction attribute
alexander-alderman-webb 306741e
.
alexander-alderman-webb aea7855
Merge branch 'master' into webb/langchain-ai-prompt-message
alexander-alderman-webb 6a7c409
handle content lists
alexander-alderman-webb 1d07d7a
old langchain compatible
alexander-alderman-webb 38c52fe
more defensive handling of content parts
alexander-alderman-webb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System instructions field uses wrong key name
Medium Severity
The
_transform_system_instructionsfunction creates dictionaries with"content"as the key, but the docstring example inconsts.pyand other integrations (anthropic, pydantic_ai) consistently use"text"as the key for text parts. The docstring shows{"type": "text", "text": "You are a helpful assistant."}but the implementation produces{"type": "text", "content": "..."}. This inconsistency will cause the langchain integration to produce data in a different format than other integrations and what's documented.Additional Locations (2)
sentry_sdk/_types.py#L362-L365sentry_sdk/consts.py#L544-L549