ref: Remove _capture_experimental_log scope parameter#4424
Merged
szokeasaurusrex merged 2 commits intomasterfrom Jun 5, 2025
Merged
ref: Remove _capture_experimental_log scope parameter#4424szokeasaurusrex merged 2 commits intomasterfrom
_capture_experimental_log scope parameter#4424szokeasaurusrex merged 2 commits intomasterfrom
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4424 +/- ##
==========================================
+ Coverage 80.67% 80.68% +0.01%
==========================================
Files 142 142
Lines 15982 15986 +4
Branches 2729 2732 +3
==========================================
+ Hits 12893 12899 +6
+ Misses 2232 2231 -1
+ Partials 857 856 -1
|
4280451 to
642e3db
Compare
a903eb6 to
285abb0
Compare
642e3db to
b553ca0
Compare
We are always just using the current scope anyway; it is less confusing if we eliminate the parameter
b553ca0 to
6eba950
Compare
285abb0 to
076e4d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are always just using the current scope anyway; it is less confusing if we eliminate the parameter
Stacked on: