[2.0] Public API changes #682
Conversation
Jean85
left a comment
Jean85
left a comment
There was a problem hiding this comment.
The only blocking change that I see is the transport as a dep and not as a config.
Everything else is great! This seems a great simplification of a few things, and I'm happy to see that tests are largely untouched, PHPT too! 👍
ste93cry
left a comment
ste93cry
left a comment
There was a problem hiding this comment.
Nice work, really! Just one suggestion for the future, not strictly related to this project: if you have such big changes to do try to address them as separate PRs that act on a small subset of the overall changes, otherwise the code review will be a mess and will be much more difficult for reviewers to understand. Also having smaller PRs means that the history of the project will be more explicative of what happened and why
Jean85
left a comment
Jean85
left a comment
There was a problem hiding this comment.
Overall it LGTM; I've found a few blocking issues, but all small.
I've opened two separate issues to track stuff afterwards and not here.
Add sdk identifier, Bump protocol version
HazAT
force-pushed
the
feat/sdk-changes
branch
from
4b8e97b to
5b76c17
Compare
This is only a part of changes if I do everything in one go it's probably too much to review.