[2.0] feat: Add global SDK #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
suggested changes
Oct 29, 2018
Makefile
Outdated
|
|
||
| phpstan: | ||
| vendor/bin/phpstan analyse | ||
| vendor/bin/phpstan analyse src tests -c phpstan.neon -l 7 |
Contributor
There was a problem hiding this comment.
Those settings are hard-coded in the configuration, they are not needed.
composer.json
Outdated
| } | ||
| }, | ||
| "autoload-dev": { | ||
| "files": ["src/Sdk.php"], |
Contributor
There was a problem hiding this comment.
You shouldn't add it twice to the autoloader, the previous one is always used.
composer.json
Outdated
| } | ||
| }, | ||
| "autoload-dev": { | ||
| "files": ["src/Sdk.php"], |
Contributor
There was a problem hiding this comment.
Suggested change
| "files": ["src/Sdk.php"], |
src/ClientBuilderInterface.php
Outdated
| * Gets the instance of the client built using the configured options. | ||
| * | ||
| * @return ClientInterface | ||
| * @return Client |
Contributor
There was a problem hiding this comment.
Please use the interface for extendability.
Suggested change
| * @return Client | |
| * @return ClientInterface |
src/ClientBuilderInterface.php
Outdated
| * @return Client | ||
| */ | ||
| public function getClient(); | ||
| public function getClient(): Client; |
Contributor
There was a problem hiding this comment.
Suggested change
| public function getClient(): Client; | |
| public function getClient(): ClientInterface; |
src/State/Hub.php
Outdated
| * | ||
| * @var Hub | ||
| */ | ||
| public static $currentHub; |
Contributor
There was a problem hiding this comment.
Suggested change
| public static $currentHub; | |
| private static $currentHub; |
Jean85
approved these changes
Oct 29, 2018
Member
Author
|
I will merge this now, tests work besides the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the "global" SDK to the SDK 🙃
Which means it should enable stuff like:
Internally it uses a
Hub,ScopeandClientto make everything work.