feat(sentry): Add sentry #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| let parsed: Value = serde_json::from_reader(fs::File::open(&values_file)?)?; | ||
|
|
||
| // Extract generated_at if present |
Member
There was a problem hiding this comment.
and because the json should always generated by the sentry options write, this property should also always be present right
| } | ||
| } | ||
|
|
||
| transaction.finish(); |
Member
There was a problem hiding this comment.
do we know how long this could take? does it block the main thread?
Member
Author
There was a problem hiding this comment.
i do not know, but don't think this overhead would be too important i'd assume its < 1 sec and won't impact option reads at all which is the important part
hubertdeng123
commented
Jan 23, 2026
| /// Uses a custom Client that is completely isolated from the host application's Sentry setup. | ||
| static SENTRY_HUB: OnceLock<Arc<sentry::Hub>> = OnceLock::new(); | ||
|
|
||
| fn get_sentry_hub() -> &'static Arc<sentry::Hub> { |
Member
Author
There was a problem hiding this comment.
You may ask why this is necessary? It's because I don't want to conflict with a user's sentry instance where they use init(). Creating an entirely different hub here ensures we only send to our DSN
kenzoengineer
approved these changes
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/getsentry/issue/DI-1457/observability-into-option-reads-and-propagation-time