Skip to content

ref(replay): Extract flush min and max delay default values to constants #6612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2023
Merged

ref(replay): Extract flush min and max delay default values to constants #6612

merged 2 commits into from
Jan 4, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Dec 22, 2022

Following up on the PR review in #6593, this PR extracts the default values of flush min and max delays into constants.

Decided to pull this into its own PR to not clutter the original one with additional changes.

@Lms24 Lms24 added the Package: replay Issues related to the Sentry Replay SDK label Dec 22, 2022
@Lms24 Lms24 requested a review from billyvg December 22, 2022 17:35
@Lms24 Lms24 self-assigned this Dec 22, 2022
@Lms24 Lms24 mentioned this pull request Dec 22, 2022
Merged
billyvg
billyvg approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

mydea
mydea approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.81 KB (+0.02% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 61.34 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.58 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified) 54.93 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 20.34 KB (0%)
@sentry/browser - Webpack (minified) 66.46 KB (0%)
@sentry/react - Webpack (gzipped + minified) 20.36 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.62 KB (0%)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.76 KB (+0.02% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 25.2 KB (-0.01% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 41.61 KB (-0.01% 🔽)
@sentry/replay - Webpack (gzipped + minified) 37.62 KB (0%)

Base automatically changed from lms-replay-debounce to master January 4, 2023 08:17
@Lms24 Lms24 force-pushed the lms-replay-flush-delay-consts branch from 2a4c18c to c9f1294 Compare January 4, 2023 08:26
@Lms24 Lms24 enabled auto-merge (squash) January 4, 2023 08:26
@Lms24 Lms24 force-pushed the lms-replay-flush-delay-consts branch from c9f1294 to db5d982 Compare January 4, 2023 09:23
@Lms24 Lms24 merged commit b03a32b into master Jan 4, 2023
@Lms24 Lms24 deleted the lms-replay-flush-delay-consts branch January 4, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

@mydea mydea mydea approved these changes

Assignees

@Lms24 Lms24

Labels
Package: replay Issues related to the Sentry Replay SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lms24 @billyvg @mydea