fix(solidstart): Support rolldownOptions in instrumentation file plugin - #24863
Merged
Merged
Conversation
…ugin In Vite 8, `build.rollupOptions` is a deprecated alias of `build.rolldownOptions`. When a plugin's `config` hook returns both and they differ, Vite ignores `rollupOptions`. Spreading a config that already set `rolldownOptions` and then writing `rollupOptions` therefore dropped the instrumentation file from the build inputs. Read `rolldownOptions` with a fallback to `rollupOptions`, and write the input back only under the key the config already uses. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2923757. Configure here.
Lms24
marked this pull request as ready for review
September 30, 2026 08:13
Lms24
requested review from
nicohrubec and
s1gr1d
and removed request for
a team
September 30, 2026 08:13
nicohrubec
approved these changes
Sep 30, 2026
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Vite 8,
rollupOptionsis a deprecated alias ofrolldownOptions, and Vite ignoresrollupOptionswhen a plugin returns both. The plugin now reads either key and writes the input back only under the one the config already uses, so older Vite keeps working.Follow-up to #24746 (comment) (i.e. our Vite 8 bump surfaced this. It's not a breaking change. Only future proofing the solid start injection for Vite 8)