test(test-utils): Extract Cloudflare Worker deploys into test-utils/cloudflare - #24815
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
JPeer264
added this pull request to stack #24817
September 29, 2026 08:43
Contributor
size-limit report 📦
|
JPeer264
marked this pull request as ready for review
September 29, 2026 09:32
andreiborza
approved these changes
Sep 29, 2026
…cloudflare` The global setup and teardown that deploy and delete a real Worker lived in cloudflare-workers-send-to-sentry. The next send-to-sentry app needs the same steps, so they move to a shared `@sentry-internal/test-utils/cloudflare` entrypoint, and each app keeps a global setup and teardown of one statement. The DSN and other values now go up with `wrangler deploy --secrets-file` instead of plain-text `--var`, so wrangler does not print them and API keys are not kept as plain text on the Worker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-utils/cloudflare` Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/test-utils-cloudflare-helpers
branch
from
September 29, 2026 13:51
c87adbf to
8263bf2
Compare
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All files are moved 1:1 to the
@sentry-internal/test-utils/cloudflarehelper, so we can reuse it in the future for other tests as wellThe global setup and teardown that deploy and delete a real Worker for
cloudflare-workers-send-to-sentrymove to a new@sentry-internal/test-utils/cloudflareentrypoint, so the next send-to-sentry app can use the same steps. Each app keeps a global setup and teardown of one statement.The helper now uploads the DSN and any other values with
wrangler deploy --secrets-fileinstead of plain-text--var. Then wrangler does not print them in the deploy log, and API keys (for example the OpenRouter key of the Flue app) are not kept as plain-text vars on the Worker. The Worker code reads the DSN fromenvas before.🤖 Generated with Claude Code