Skip to content

test(cloudflare): Port the http-server integration suites to span streaming - #24195

Merged
JPeer264 merged 1 commit into
jp/cf-int-tests-bindings-streamingfrom
jp/cf-int-tests-http-server-streaming
Sep 29, 2026
Merged

JPeer264 merged 1 commit into
jp/cf-int-tests-bindings-streamingfrom
jp/cf-int-tests-http-server-streaming

Conversation

@JPeer264

@JPeer264 JPeer264 commented Sep 8, 2026

Copy link
Copy Markdown
Member

Removes the traceLifecycle: 'static' pin from the five suites/integrations/http-server* suites.

Nothing else changes. These suites cover request body capture, so they assert on the event the worker sends and never on a transaction. None of them sets tracesSampleRate either, so the pin only ever selected a trace lifecycle for a client that emits no spans in the first place.

Part of #24148

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.24 kB - -
@sentry/browser - with treeshaking flags 27.5 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 27.4 kB - -
@sentry/browser (incl. Tracing) 51.15 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 51.18 kB - -
@sentry/browser (incl. Tracing, Profiling) 54.18 kB - -
@sentry/browser (incl. Tracing, Replay) 90.76 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 79.86 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 95.46 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 108.41 kB - -
@sentry/browser (incl. Feedback) 46.76 kB - -
@sentry/browser (incl. sendFeedback) 34.3 kB - -
@sentry/browser (incl. FeedbackAsync) 39.41 kB - -
@sentry/browser (incl. Metrics) 30.25 kB - -
@sentry/browser (incl. Logs) 30.51 kB - -
@sentry/browser (incl. Metrics & Logs) 31.18 kB - -
@sentry/react 31.08 kB - -
@sentry/react (incl. Tracing) 53.54 kB - -
@sentry/vue 36.74 kB - -
@sentry/vue (incl. Tracing) 53.7 kB - -
@sentry/svelte 29.26 kB - -
CDN Bundle 31.02 kB - -
CDN Bundle (incl. Tracing) 51.78 kB - -
CDN Bundle (incl. Logs, Metrics) 33.29 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 53.75 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 74 kB - -
CDN Bundle (incl. Tracing, Replay) 89.37 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 91.34 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 95.53 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 97.5 kB - -
CDN Bundle - uncompressed 91.66 kB - -
CDN Bundle (incl. Tracing) - uncompressed 154.05 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 98.23 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 160 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 227.8 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 273.78 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 279.72 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 287.48 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 293.41 kB - -
@sentry/nextjs (client) 55.78 kB - -
@sentry/sveltekit (client) 51.6 kB - -
@sentry/core/server 39.99 kB - -
@sentry/core/browser 13.63 kB - -
@sentry/node 141.92 kB +0.01% +13 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 82.88 kB - -
@sentry/node - without tracing 90.94 kB +0.02% +14 B 🔺
@sentry/node - without channel injection 120.3 kB +0.01% +9 B 🔺
@sentry/aws-serverless 99.17 kB +0.01% +5 B 🔺
@sentry/cloudflare (withSentry) - minified 206.64 kB - -
@sentry/cloudflare (withSentry) 514.04 kB - -

View base workflow run

@JPeer264
JPeer264 force-pushed the jp/cf-int-tests-http-server-streaming branch from 79ecf0a to 01821a6 Compare September 19, 2026 15:46
@JPeer264 JPeer264 self-assigned this Sep 21, 2026
@JPeer264
JPeer264 marked this pull request as ready for review September 21, 2026 06:45
@JPeer264
JPeer264 requested a review from a team as a code owner September 21, 2026 06:45
@JPeer264
JPeer264 requested review from andreiborza, isaacs and msonnb and removed request for a team September 21, 2026 06:45
@github-actions

Copy link
Copy Markdown
Contributor

👋 @isaacs, @msonnb, @andreiborza — Please review this PR when you get a chance!

@JPeer264
JPeer264 force-pushed the jp/cf-int-tests-http-server-streaming branch from 01821a6 to 9393561 Compare September 27, 2026 09:54
@JPeer264
JPeer264 force-pushed the jp/cf-int-tests-http-server-streaming branch 2 times, most recently from 26e3a4b to 98ad345 Compare September 29, 2026 08:18
@github-actions

Copy link
Copy Markdown
Contributor

👋 @isaacs, @msonnb, @andreiborza — Please review this PR when you get a chance!

…eaming

Removes the `traceLifecycle: 'static'` pin from the five
`suites/integrations/http-server*` suites.

Nothing else changes. These suites cover request body capture, so they assert on
the event the worker sends and never on a transaction. None of them sets
`tracesSampleRate`, so the pin only ever selected a trace lifecycle for a client
that emits no spans either way.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@JPeer264
JPeer264 force-pushed the jp/cf-int-tests-http-server-streaming branch from 98ad345 to 48de1d7 Compare September 29, 2026 13:34
@JPeer264
JPeer264 merged commit 3740892 into develop Sep 29, 2026
43 checks passed
@JPeer264
JPeer264 deleted the jp/cf-int-tests-http-server-streaming branch September 29, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants