Skip to content

fix(hono): Use captureException from scope, not from Client - #23279

Merged
s1gr1d merged 1 commit into
developfrom
sig/fix-hono-exception
Aug 11, 2026
Merged

fix(hono): Use captureException from scope, not from Client#23279
s1gr1d merged 1 commit into
developfrom
sig/fix-hono-exception

Conversation

@s1gr1d

@s1gr1d s1gr1d commented Aug 11, 2026

Copy link
Copy Markdown
Member

Mentioned in this PR

And there's still an underlying issue with how we send the metadata of error chains, shown in tests added in this PR:

@s1gr1d
s1gr1d requested a review from a team as a code owner August 11, 2026 11:46
@s1gr1d
s1gr1d requested review from Lms24, chargome and mydea and removed request for a team August 11, 2026 11:46
@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 30.26 kB - -
@sentry/browser - with treeshaking flags 28.44 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 26.78 kB - -
@sentry/browser (incl. Tracing) 48.5 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 48.52 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.4 kB - -
@sentry/browser (incl. Tracing, Replay) 87.94 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.3 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 92.65 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 105.32 kB - -
@sentry/browser (incl. Feedback) 47.58 kB - -
@sentry/browser (incl. sendFeedback) 35.08 kB - -
@sentry/browser (incl. FeedbackAsync) 40.23 kB - -
@sentry/browser (incl. Metrics) 31.29 kB - -
@sentry/browser (incl. Logs) 31.55 kB - -
@sentry/browser (incl. Metrics & Logs) 32.24 kB - -
@sentry/react 32.06 kB - -
@sentry/react (incl. Tracing) 50.69 kB - -
@sentry/vue 35.32 kB - -
@sentry/vue (incl. Tracing) 50.45 kB - -
@sentry/svelte 30.28 kB - -
CDN Bundle 31.52 kB - -
CDN Bundle (incl. Tracing) 48.81 kB - -
CDN Bundle (incl. Logs, Metrics) 33.75 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 50.78 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 74.3 kB - -
CDN Bundle (incl. Tracing, Replay) 86.41 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.32 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 92.11 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.12 kB - -
CDN Bundle - uncompressed 93.59 kB - -
CDN Bundle (incl. Tracing) - uncompressed 146.49 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.06 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.34 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 228.98 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 265.74 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 271.58 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.43 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.26 kB - -
@sentry/nextjs (client) 53.24 kB - -
@sentry/sveltekit (client) 48.91 kB - -
@sentry/core/server 65.46 kB - -
@sentry/core/browser 51.81 kB - -
@sentry/node 117.92 kB - -
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 82.05 kB - -
@sentry/aws-serverless 91.45 kB - -
@sentry/cloudflare (withSentry) - minified 214.07 kB - -
@sentry/cloudflare (withSentry) 528.66 kB - -

View base workflow run

@s1gr1d
s1gr1d merged commit 80d4b6a into develop Aug 11, 2026
50 checks passed
@s1gr1d
s1gr1d deleted the sig/fix-hono-exception branch August 11, 2026 12:16
s1gr1d added a commit that referenced this pull request Aug 11, 2026
JPeer264 pushed a commit that referenced this pull request Aug 12, 2026
Mentioned in this PR
- #22979


And there's still an underlying issue with how we send the metadata of
error chains, shown in tests added in this PR:
- #23244
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants