Skip to content

chore(e2e): Bump @solidjs/router to v1 in solidstart test apps - #23164

Merged
andreiborza merged 1 commit into
developfrom
ab/bump-solidstart-e2e-router-v1
Aug 7, 2026
Merged

chore(e2e): Bump @solidjs/router to v1 in solidstart test apps#23164
andreiborza merged 1 commit into
developfrom
ab/bump-solidstart-e2e-router-v1

Conversation

@andreiborza

Copy link
Copy Markdown
Member

What

Bump @solidjs/router from ^0.15.0 to ^1.0.0 in the SolidStart 1 e2e test apps.

  • solidstart, solidstart-spa, solidstart-top-level-import, solidstart-dynamic-import

Why

#23162 widened the @solidjs/router peer range to >=0.13.4 <2.0.0-0, but only the solidstart-2 app ran against v1, so the SolidStart 1 + router v1 combination the range now advertises had no coverage. The equivalent bump on v10 (#23163) passes all four suites locally.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@andreiborza
andreiborza marked this pull request as ready for review August 7, 2026 17:13
@andreiborza
andreiborza requested a review from logaretm August 7, 2026 17:13
@andreiborza
andreiborza enabled auto-merge (squash) August 7, 2026 17:14
@andreiborza
andreiborza disabled auto-merge August 7, 2026 17:14
@andreiborza
andreiborza enabled auto-merge (squash) August 7, 2026 17:14
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 30.35 kB - -
@sentry/browser - with treeshaking flags 28.52 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 26.85 kB - -
@sentry/browser (incl. Tracing) 49.1 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 49.13 kB - -
@sentry/browser (incl. Tracing, Profiling) 53.9 kB - -
@sentry/browser (incl. Tracing, Replay) 88.45 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.82 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 93.15 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 105.84 kB - -
@sentry/browser (incl. Feedback) 47.69 kB - -
@sentry/browser (incl. sendFeedback) 35.18 kB - -
@sentry/browser (incl. FeedbackAsync) 40.33 kB - -
@sentry/browser (incl. Metrics) 31.43 kB - -
@sentry/browser (incl. Logs) 31.66 kB - -
@sentry/browser (incl. Metrics & Logs) 32.34 kB - -
@sentry/react 32.14 kB - -
@sentry/react (incl. Tracing) 51.29 kB - -
@sentry/vue 35.45 kB - -
@sentry/vue (incl. Tracing) 51.07 kB - -
@sentry/svelte 30.38 kB - -
CDN Bundle 32.32 kB - -
CDN Bundle (incl. Tracing) 49.65 kB - -
CDN Bundle (incl. Logs, Metrics) 33.84 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 50.94 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 74.38 kB - -
CDN Bundle (incl. Tracing, Replay) 87.17 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.45 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 93.05 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94.3 kB - -
CDN Bundle - uncompressed 95.83 kB - -
CDN Bundle (incl. Tracing) - uncompressed 148.93 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 100.42 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 152.91 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 229.34 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 268.18 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 272.15 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 281.88 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 285.83 kB - -
@sentry/nextjs (client) 53.84 kB - -
@sentry/sveltekit (client) 49.48 kB - -
@sentry/core/server 65.8 kB - -
@sentry/core/browser 52.04 kB - -
@sentry/node 119.48 kB +0.01% +1 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 83.46 kB - -
@sentry/aws-serverless 92.76 kB +0.01% +1 B 🔺
@sentry/cloudflare (withSentry) - minified 214.91 kB - -
@sentry/cloudflare (withSentry) 530.62 kB - -

View base workflow run

@andreiborza
andreiborza merged commit 0f558e3 into develop Aug 7, 2026
47 checks passed
@andreiborza
andreiborza deleted the ab/bump-solidstart-e2e-router-v1 branch August 7, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants