chore(e2e): Bump @solidjs/router to v1 in solidstart test apps - #23164
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
andreiborza
marked this pull request as ready for review
August 7, 2026 17:13
logaretm
approved these changes
Aug 7, 2026
andreiborza
enabled auto-merge (squash)
August 7, 2026 17:14
andreiborza
disabled auto-merge
August 7, 2026 17:14
andreiborza
enabled auto-merge (squash)
August 7, 2026 17:14
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump
@solidjs/routerfrom^0.15.0to^1.0.0in the SolidStart 1 e2e test apps.solidstart,solidstart-spa,solidstart-top-level-import,solidstart-dynamic-importWhy
#23162 widened the
@solidjs/routerpeer range to>=0.13.4 <2.0.0-0, but only thesolidstart-2app ran against v1, so the SolidStart 1 + router v1 combination the range now advertises had no coverage. The equivalent bump on v10 (#23163) passes all four suites locally.