Skip to content

feat(core)!: Use rpc span op for tRPC spans - #22914

Merged
msonnb merged 1 commit into
developfrom
ms/js-3105-rpc-op
Aug 5, 2026
Merged

feat(core)!: Use rpc span op for tRPC spans#22914
msonnb merged 1 commit into
developfrom
ms/js-3105-rpc-op

Conversation

@msonnb

@msonnb msonnb commented Jul 31, 2026

Copy link
Copy Markdown
Member

Replace rpc.server with rpc from conventions for trpc spans

Part of #22446

@linear-code

linear-code Bot commented Jul 31, 2026

Copy link
Copy Markdown

JS-3105

@msonnb

msonnb commented Jul 31, 2026

Copy link
Copy Markdown
Member Author

bugbot run

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 29.8 kB - -
@sentry/browser - with treeshaking flags 28.02 kB - -
@sentry/browser (incl. Tracing) 47.21 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 47.22 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.95 kB - -
@sentry/browser (incl. Tracing, Replay) 86.54 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 75.98 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 91.26 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 103.89 kB - -
@sentry/browser (incl. Feedback) 47.1 kB - -
@sentry/browser (incl. sendFeedback) 34.64 kB - -
@sentry/browser (incl. FeedbackAsync) 39.75 kB - -
@sentry/browser (incl. Metrics) 30.87 kB - -
@sentry/browser (incl. Logs) 31.11 kB - -
@sentry/browser (incl. Metrics & Logs) 31.78 kB - -
@sentry/react 31.59 kB - -
@sentry/react (incl. Tracing) 49.46 kB - -
@sentry/vue 34.87 kB - -
@sentry/vue (incl. Tracing) 49.19 kB - -
@sentry/svelte 29.82 kB - -
CDN Bundle 31.87 kB - -
CDN Bundle (incl. Tracing) 47.54 kB - -
CDN Bundle (incl. Logs, Metrics) 33.41 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 48.94 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 72.75 kB - -
CDN Bundle (incl. Tracing, Replay) 85.18 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 86.5 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 91.01 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.31 kB - -
CDN Bundle - uncompressed 94.7 kB - -
CDN Bundle (incl. Tracing) - uncompressed 142.18 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 99.32 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 146.16 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 224.02 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 261.43 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 265.4 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 275.14 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 279.09 kB - -
@sentry/nextjs (client) 52.03 kB - -
@sentry/sveltekit (client) 47.65 kB - -
@sentry/core/server 65.56 kB +0.1% +64 B 🔺
@sentry/core/browser 51.84 kB - -
@sentry/node 120.19 kB - -
@sentry/node/import (ESM hook with diagnostics-channel injection) 0 B added added
@sentry/node - without tracing 83.64 kB - -
@sentry/aws-serverless 92.3 kB - -
@sentry/cloudflare (withSentry) - minified 218.64 kB - -
@sentry/cloudflare (withSentry) 538.65 kB - -

View base workflow run

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 31b7614. Configure here.

Comment thread packages/core/src/integrations/mcp-server/attributes.ts Outdated

@Lms24 Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should remove MCP ops. Our MCP prebuilt dashboards (like this one) depend on the MCP ops. You're right, they'Re RPC calls under the hood but I think MCP warrants its own span ops.

@msonnb
msonnb force-pushed the ms/js-3105-rpc-op branch from 31b7614 to 5071778 Compare August 4, 2026 14:47
@msonnb msonnb changed the title feat(core)!: Use rpc span op for MCP and tRPC feat(core)!: Use rpc span op for tRPC spans Aug 4, 2026
@msonnb
msonnb marked this pull request as ready for review August 4, 2026 14:54
@msonnb
msonnb requested a review from Lms24 August 4, 2026 14:54
@msonnb
msonnb merged commit e59be58 into develop Aug 5, 2026
266 checks passed
@msonnb
msonnb deleted the ms/js-3105-rpc-op branch August 5, 2026 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants