Skip to content

test(astro): Add dynamic routes astro-4 tests #17102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 21, 2025
Merged

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Jul 21, 2025

Extracting astro-4 test cases (same as in astro-5) in a new PR while working on route parametrization.

Part of #16686

@s1gr1d s1gr1d requested a review from Lms24 July 21, 2025 09:09
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Catch-All Route Naming Mismatch

The e2e test for Astro catch-all routes ([...path].astro) incorrectly expects the server transaction name to be 'GET /catchAll/[path]'. Astro's route instrumentation correctly reports the transaction name as 'GET /catchAll/[...path]', retaining the ellipsis. This mismatch causes the test assertion to fail.

dev-packages/e2e-tests/test-applications/astro-4/tests/tracing.dynamic.test.ts#L296-L299

expect(serverPageRequestTxn).toMatchObject({
transaction: 'GET /catchAll/[path]',
transaction_info: { source: 'route' },

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

@s1gr1d s1gr1d merged commit cde0037 into develop Jul 21, 2025
143 of 144 checks passed
@s1gr1d s1gr1d deleted the sig/astro-4-tests branch July 21, 2025 09:32
s1gr1d added a commit that referenced this pull request Jul 24, 2025
Extracting astro-4 test cases (same as in astro-5) in a new PR while
working on route parametrization.

Part of #16686
s1gr1d added a commit that referenced this pull request Jul 24, 2025
Backport of all server-related parametrization in Astro:

- #17054
- #17085
- #17102
- #17105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants