test(astro): Add dynamic routes astro-4 tests #17102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
approved these changes
Jul 21, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Catch-All Route Naming Mismatch
The e2e test for Astro catch-all routes ([...path].astro) incorrectly expects the server transaction name to be 'GET /catchAll/[path]'. Astro's route instrumentation correctly reports the transaction name as 'GET /catchAll/[...path]', retaining the ellipsis. This mismatch causes the test assertion to fail.
dev-packages/e2e-tests/test-applications/astro-4/tests/tracing.dynamic.test.ts#L296-L299
Was this report helpful? Give feedback by reacting with 👍 or 👎
s1gr1d
added a commit
that referenced
this pull request
Jul 24, 2025
Extracting astro-4 test cases (same as in astro-5) in a new PR while working on route parametrization. Part of #16686
s1gr1d
added a commit
that referenced
this pull request
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting astro-4 test cases (same as in astro-5) in a new PR while working on route parametrization.
Part of #16686