Skip to content

ref(v9/browser): Remove unnecessary CLS web vital check #17096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jul 21, 2025

Backport of #17090:

Just a minor cleanup from a TODO I left a while ago. We can safely
remove this check because CLS isn't reported before FCP is reported.

Just a minor cleanup from a TODO I left a while ago. We can safely
remove this check because CLS isn't reported before FCP is reported.
@Lms24 Lms24 changed the title ref(browser): Remove unnecessary CLS web vital check (#17090) ref(v9/browser): Remove unnecessary CLS web vital check (#17090) Jul 21, 2025
@Lms24 Lms24 changed the base branch from develop to v9 July 21, 2025 07:09
@Lms24 Lms24 self-assigned this Jul 21, 2025
@Lms24 Lms24 requested review from a team, stephanie-anderson, chargome and msonnb and removed request for a team and stephanie-anderson July 21, 2025 07:09
@Lms24 Lms24 changed the title ref(v9/browser): Remove unnecessary CLS web vital check (#17090) ref(v9/browser): Remove unnecessary CLS web vital check Jul 21, 2025
Copy link
Contributor

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 23.75 kB - -
@sentry/browser - with treeshaking flags 22.34 kB - -
@sentry/browser (incl. Tracing) 39.61 kB -0.02% -6 B 🔽
@sentry/browser (incl. Tracing, Replay) 77.78 kB -0.01% -7 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.59 kB -0.02% -7 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 82.48 kB -0.01% -8 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 94.58 kB -0.01% -9 B 🔽
@sentry/browser (incl. Feedback) 40.45 kB - -
@sentry/browser (incl. sendFeedback) 28.43 kB - -
@sentry/browser (incl. FeedbackAsync) 33.34 kB - -
@sentry/react 25.5 kB - -
@sentry/react (incl. Tracing) 41.59 kB -0.02% -7 B 🔽
@sentry/vue 28.18 kB - -
@sentry/vue (incl. Tracing) 41.4 kB -0.02% -8 B 🔽
@sentry/svelte 23.78 kB - -
CDN Bundle 25.18 kB - -
CDN Bundle (incl. Tracing) 39.41 kB -0.02% -7 B 🔽
CDN Bundle (incl. Tracing, Replay) 75.41 kB -0.01% -5 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 80.88 kB -0.01% -7 B 🔽
CDN Bundle - uncompressed 73.44 kB - -
CDN Bundle (incl. Tracing) - uncompressed 116.85 kB -0.02% -12 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 230.99 kB -0.01% -12 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 243.8 kB -0.01% -12 B 🔽
@sentry/nextjs (client) 43.61 kB -0.02% -7 B 🔽
@sentry/sveltekit (client) 40.03 kB -0.02% -7 B 🔽
@sentry/node-core 47.24 kB - -
@sentry/node 143.81 kB - -
@sentry/node - without tracing 91.31 kB - -
@sentry/aws-serverless 102.75 kB - -

View base workflow run

@Lms24 Lms24 merged commit 2f069f5 into v9 Jul 21, 2025
35 checks passed
@Lms24 Lms24 deleted the lms/v9-ref-browser-cls-check branch July 21, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants