Skip to content

feat(browser)!: Remove FID web vital collection #17076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jul 18, 2025

This PR removes the FID web vital collection logic from the browser SDK. This is a behaviour breaking change and should not be backported to v9.

For reasons see #16560 but the TLDR is that FID has long been deprecated and replaced by INP.

Added a note to the changelog with possible implications on the product. Also thought of a minor edge case where the removal could have an effect on SDK code: If a filtering decision in beforeSend depends on the presence of the FID measurement. A very niche case IMHO but probably good to mention anyway.

closes #16560

@Lms24 Lms24 self-assigned this Jul 18, 2025
Copy link
Contributor

github-actions bot commented Jul 18, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.75 kB - -
@sentry/browser - with treeshaking flags 22.34 kB - -
@sentry/browser (incl. Tracing) 39.41 kB -0.53% -208 B 🔽
@sentry/browser (incl. Tracing, Replay) 77.54 kB -0.33% -250 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.38 kB -0.33% -217 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 82.24 kB -0.31% -251 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 94.35 kB -0.26% -237 B 🔽
@sentry/browser (incl. Feedback) 40.45 kB - -
@sentry/browser (incl. sendFeedback) 28.43 kB - -
@sentry/browser (incl. FeedbackAsync) 33.34 kB - -
@sentry/react 25.5 kB - -
@sentry/react (incl. Tracing) 41.4 kB -0.48% -197 B 🔽
@sentry/vue 28.18 kB - -
@sentry/vue (incl. Tracing) 41.22 kB -0.46% -189 B 🔽
@sentry/svelte 23.78 kB - -
CDN Bundle 25.18 kB - -
CDN Bundle (incl. Tracing) 39.22 kB -0.51% -201 B 🔽
CDN Bundle (incl. Tracing, Replay) 75.21 kB -0.28% -206 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 80.65 kB -0.3% -239 B 🔽
CDN Bundle - uncompressed 73.44 kB - -
CDN Bundle (incl. Tracing) - uncompressed 116.11 kB -0.65% -748 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 230.09 kB -0.4% -903 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 242.91 kB -0.38% -903 B 🔽
@sentry/nextjs (client) 43.43 kB -0.45% -195 B 🔽
@sentry/sveltekit (client) 39.84 kB -0.5% -200 B 🔽
@sentry/node-core 47.24 kB - -
@sentry/node 143.81 kB - -
@sentry/node - without tracing 91.31 kB - -
@sentry/aws-serverless 102.75 kB +0.01% +1 B 🔺

View base workflow run

@Lms24 Lms24 force-pushed the lms/feat-remove-fid branch from 25ad7cb to c35192d Compare July 18, 2025 09:35
@Lms24 Lms24 requested review from a team, s1gr1d, RulaKhaled and edwardgou-sentry and removed request for a team July 18, 2025 14:52
@Lms24 Lms24 marked this pull request as ready for review July 18, 2025 14:52
@Lms24 Lms24 requested a review from a team as a code owner July 18, 2025 14:52
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Jul 18, 2025

❌ Unsupported file format

Upload processing failed due to unsupported file format. Please review the parser error message:
Error deserializing json

Caused by:
expected value at line 1 column 1

For more help, visit our troubleshooting guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove collection of FID web vital
1 participant