fix(otel): Don't ignore child spans after the root is sent #16416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a critical issue I was having with Mastra where almost all my spans from a workflow run were getting stuck due to their parent span being sent almost immediately. I'm guessing this has to do something with `async` stuff going on. Regardless, by treating these children as 'root spans' I was able to get them out and displayed correctly in Spotlight. What this does is creates a 5-min capped 'already sent span ids' cache and treats any span that has a parent id in this list as a root span to get them unstuck.
size-limit report 📦
|
andreiborza
reviewed
May 30, 2025
dev-packages/opentelemetry-v2-tests/test/integration/transactions.test.ts
Outdated
Show resolved
Hide resolved
Yeah was my next step, just got busy with other stuff. Thanks a lot for the review! |
|
@andreiborza @AbhiPrasad any idea about the Next.js test failures? Not sure if they are releated to my change and if they are, whether the tests need updating or there's something I actually broke? |
|
The test failure is showing the span description is not correct. In my opinion this means either
This is not a flake, we don't usually get errors like this. I do lack context about Next specifics nowadays, so we can wait till Monday to get more feedback from the folks who own that SDK now (@chargome and @RulaKhaled) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a critical issue I was having with Mastra where almost all my spans from a workflow run were getting stuck due to their parent span being sent almost immediately. I'm guessing this has to do something with
asyncstuff going on. Regardless, by treating these children as 'root spans' I was able to get them out and displayed correctly in Spotlight.What this does is creates a 5-min capped 'already sent span ids' cache and treats any span that has a parent id in this list as a root span to get them unstuck.