Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Upgrade import-in-the-middle to 1.11.0 #13107

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

AbhiPrasad
Copy link
Member

ref https://github.com/nodejs/import-in-the-middle/releases/tag/import-in-the-middle-v1.11.0

ref #12806

Bumping this for the bug fix, we can expose the registerOptions in another PR.

@AbhiPrasad AbhiPrasad requested review from timfish and s1gr1d July 30, 2024 14:16
@AbhiPrasad AbhiPrasad self-assigned this Jul 30, 2024
@@ -126,18 +126,6 @@ other imports:
}
```

If you are getting an `import-in-the-middle` error message, add the package with a minimum version of `1.10.0` as a
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s1gr1d I removed this note because we now pin IITM versions in @sentry/node, so folks should not run into stale versions anymore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tested this and yes, it works :)

Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 22.45 KB (0%)
@sentry/browser (incl. Tracing) 34.22 KB (0%)
@sentry/browser (incl. Tracing, Replay) 70.26 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.59 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 74.66 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 87.24 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 89.08 KB (0%)
@sentry/browser (incl. metrics) 26.75 KB (0%)
@sentry/browser (incl. Feedback) 39.37 KB (0%)
@sentry/browser (incl. sendFeedback) 27.06 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.7 KB (0%)
@sentry/react 25.22 KB (0%)
@sentry/react (incl. Tracing) 37.22 KB (0%)
@sentry/vue 26.6 KB (0%)
@sentry/vue (incl. Tracing) 36.06 KB (0%)
@sentry/svelte 22.58 KB (0%)
CDN Bundle 23.64 KB (0%)
CDN Bundle (incl. Tracing) 35.88 KB (0%)
CDN Bundle (incl. Tracing, Replay) 70.26 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.53 KB (0%)
CDN Bundle - uncompressed 69.37 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 106.31 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 217.95 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 230.78 KB (0%)
@sentry/nextjs (client) 37.08 KB (0%)
@sentry/sveltekit (client) 34.81 KB (0%)
@sentry/node 114.55 KB (+2.36% 🔺)
@sentry/node - without tracing 89.33 KB (0%)
@sentry/aws-serverless 98.5 KB (-0.01% 🔽)

@AbhiPrasad AbhiPrasad merged commit 51f85e6 into develop Jul 30, 2024
127 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-upgrade-iitm-1.11.0 branch July 30, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants