Skip to content

fix(core): Avoid showing success message if upload was disabled or nothing was uploaded #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jul 11, 2025

This bugged me and many users for a while: Because of a weird control flow in the debugID source maps upload plugin, we'd print the "Successfully uploaded source maps to Sentry" message if

  • a bunch of important preconditions for uploading were not met (e.g. missing auth token).
    • I think this was actually a pretty bad bug because it would cause Sentry CLI to do validation when it was called although we could have avoided this entirely.
  • we didn't upload anything (i.e. we found 0 assets)

This PR fixes both cases.

closes #670

@Lms24 Lms24 requested review from chargome and andreiborza July 11, 2025 12:54
@Lms24 Lms24 self-assigned this Jul 11, 2025
@Lms24 Lms24 changed the title fix(core): Avoid showing success message if nothing was uploaded fix(core): Avoid showing success message if upload was disabled or nothing was uploaded Jul 14, 2025
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@Lms24 Lms24 merged commit 33a18f9 into main Jul 15, 2025
37 of 40 checks passed
@Lms24 Lms24 deleted the lms/fix-wrong-success-message branch July 15, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundler plugin says upload successful, when Sentry CLI fails
3 participants