Skip to content

fix(breadcrumbs): Deduplicate battery breadcrumbs #4561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: rz/perf/less-ipc
Choose a base branch
from

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jul 16, 2025

📜 Description

  • Remember last state of the battery breadcrumbs
    • Do not capture if the level or charging state is the same (or similar)

💡 Motivation and Context

Closes getsentry/sentry-react-native#4668

💚 How did you test it?

Manually + automated

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jul 16, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 414.94 ms 476.12 ms 61.19 ms
Size 1.58 MiB 2.09 MiB 520.78 KiB

Baseline results on branch: rz/perf/less-ipc

Startup times

Revision Plain With Sentry Diff
91ac06a 386.02 ms 407.53 ms 21.51 ms

App size

Revision Plain With Sentry Diff
91ac06a 1.58 MiB 2.09 MiB 520.52 KiB

Previous results on branch: rz/fix/diff-battery-crumbs

Startup times

Revision Plain With Sentry Diff
4522edb 390.10 ms 421.50 ms 31.40 ms
b0bed47 400.72 ms 441.62 ms 40.90 ms

App size

Revision Plain With Sentry Diff
4522edb 1.58 MiB 2.09 MiB 520.79 KiB
b0bed47 1.58 MiB 2.09 MiB 520.80 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant