perf(connectivity): Cache network capabilities and status to reduce IPC calls #4560
+840
−164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
onLost
/onUnavailable
would immediately send DISCONNECTED now as opposed to retrievingconnectionStatus
againisSignificantChange
check, becauseonNetworkCapabilitiesChanged
can be called many times due to bandwidth change/etc. and we're only interested in transport/connectivity changesRan a test with perfetto to count the number of binder calls, and these are the results:
Before (83 binder calls from SentryExecService)
After (5 binder calls from SentryExecService)
💡 Motivation and Context
Fixes #4200
💚 How did you test it?
Manually + automated
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps