Skip to content

Add option to mask widgets by package name #4553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add option to mask widgets by package name #4553

wants to merge 3 commits into from

Conversation

markushi
Copy link
Member

📜 Description

Extends SentryReplayOptions to allow package names for masking.

💡 Motivation and Context

Implements #4393

💚 How did you test it?

Added tests

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

markushi added 2 commits July 11, 2025 10:35
@markushi
feat(session-replay): Add package wildcard masking support
3ee3aee 
- Add addMaskPackage() and addUnmaskPackage() methods to SentryReplayOptions
- Implement PatternUtils for suffix wildcard pattern matching (e.g., 'com.thirdparty.*')
- Update ViewHierarchyNode masking logic to support package patterns
- Add comprehensive unit tests for pattern matching functionality
- Update API files to reflect new public methods
- Include package masking info in RRWebOptionsEvent

Resolves #4393
@markushi
docs: Add CLAUDE.md development guide
7fe87c6 
- Add overview of sentry-java project for Claude AI assistant
- Include tech stack information and key commands
- Document contributing guidelines and best practices
- Provide useful resources for development
@github-actions GitHub Actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add option to mask widgets by package name ([#4553](https://github.com/getsentry/sentry-java/pull/4553))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 7fe87c6

@github-actions GitHub Actions
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 474.30 ms 530.52 ms 56.22 ms
Size 1.58 MiB 2.09 MiB 519.45 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adinauer adinauer Awaiting requested review from adinauer adinauer will be requested when the pull request is marked ready for review adinauer is a code owner

@romtsn romtsn Awaiting requested review from romtsn romtsn will be requested when the pull request is marked ready for review romtsn is a code owner

@stefanosiano stefanosiano Awaiting requested review from stefanosiano stefanosiano will be requested when the pull request is marked ready for review stefanosiano is a code owner

@lcian lcian Awaiting requested review from lcian lcian will be requested when the pull request is marked ready for review lcian is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markushi @getsentry-bot