Read build tool info from sentry-debug-meta.properties and attach it to events
#4314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcian
requested review from
adinauer,
romtsn,
stefanosiano and
markushi
as code owners
lcian
commented
Apr 3, 2025
| applyBuildTool(options, debugMetaProperties); | ||
| } | ||
| } | ||
|
|
||
| public static void applyToOptions( |
There was a problem hiding this comment.
This class and method are public and not marked as internal so I've created a new method to implement the new behavior
| .getLogger() | ||
| .log( | ||
| SentryLevel.DEBUG, "Build tool found: %s, version %s", buildTool, buildToolVersion); | ||
| SentryIntegrationPackageStorage.getInstance().addPackage(buildTool, buildToolVersion); |
There was a problem hiding this comment.
I don't like that we're abusing the sdk.packages field of the envelope.
Should we maybe send it as sdk.build-tool or something? Even though it's not officially supported by the protocol.
Performance metrics 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Reads the build tool and its version from
sentry-debug-meta.propertiesand sends it as part of the packages.The build tool is being written to
sentry-debug-meta.propertiesby the plugin (io.sentry.build-toolset to resp.mavenandgradle).The plugins don't currently set
io.sentry.build-tool-version, so if it's not there we fall back to reporting "unknown" as the version.In a future release of the plugin we can make it so they both write
io.sentry.build-tool-versionas well.💡 Motivation and Context
Closes #4142
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Change both of the plugins to report
io.sentry.build-tool-version.