WIP: Logs for Sentry.Extensions.Logging and integrations for Sentry.AspNetCore and Sentry.Maui
#4193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| _ = logging.AddFilter<SentryAspNetCoreLoggerProvider>( | ||
| "Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware", | ||
| LogLevel.None); | ||
| _ = logging.AddFilter<SentryAspNetCoreStructuredLoggerProvider>(static (string? categoryName, LogLevel logLevel) => | ||
| { | ||
| return categoryName is null |
There was a problem hiding this comment.
are these guaranteed to be all of the categories we add?
I wonder if there's some "Constant" or something with these, we could reflect on and write a test to make sure we filter all of them out
There was a problem hiding this comment.
I'm fairly certain ... not quite positive though.
Those are the ILogger<T> usages that I found in our packages.
I definitely have to add a test for that ... probably as an ASP.NET Core integration test ... I see we have the infrastructure already setup via the "TestUtils" project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation for
Sentry.Extensions.LoggingInitial integrations for
Sentry.AspNetCoreSentry.MauiLogs: https://develop.sentry.dev/sdk/telemetry/logs/