Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show results from other Sentry sites when user clicks corresponding button #9288

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

a-hariti
Copy link
Collaborator

…ing button

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Closes #9034

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Extra resources

Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 3:22pm

@stephanie-anderson
Copy link
Contributor

Hey @a-hariti! Behaviour looks good on other sites than the landing page of docs. Could you have a look at the landing page as well? https://sentry-docs-git-search-across-all-sentry-sites.sentry.dev/

Screenshot 2024-03-01 at 11 52 21

@stephanie-anderson stephanie-anderson self-requested a review March 1, 2024 10:53
@a-hariti
Copy link
Collaborator Author

a-hariti commented Mar 1, 2024

Could you please clarify the issue?

@lizokm
Copy link
Contributor

lizokm commented Mar 1, 2024

@stephanie-anderson @a-hariti hmm.... When I clicked the "search {topic} across all Sentry sites" link from the docs landing page, the first time it was initially unresponsive. I then clicked it 2 more times and it worked. I tried searching for a few more topics and the link worked the first time every time after that. Not sure why it was initially unresponsive, but I wasn't able to replicate the behavior after the first time. So to me it seems like this is working.

Screenshot 2024-03-01 at 12 13 46 PM

@lizokm lizokm merged commit 8a516b4 into master Mar 4, 2024
8 checks passed
@lizokm lizokm deleted the search-across-all-sentry-sites branch March 4, 2024 20:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search functionality for "search all sites" not working
3 participants