Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide non functioning copy button on slow connections #9281

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

a-hariti
Copy link
Collaborator

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Hide the copy button on code blocks until it is interactive

This PR closes #8139

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Extra resources

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 9:00pm

Copy link

codecov bot commented Feb 28, 2024

Bundle Report

Changes will increase total bundle size by 114 bytes ⬆️

Bundle name Size Change
sentry-docs-edge-server 3.47kB 0 bytes
sentry-docs-client 5.51MB 54 bytes ⬆️
sentry-docs-server 5.93MB 60 bytes ⬆️

Copy link
Contributor

@stephanie-anderson stephanie-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@stephanie-anderson stephanie-anderson merged commit a95991c into master Mar 1, 2024
8 checks passed
@stephanie-anderson stephanie-anderson deleted the hide-non-functional-copy-button branch March 1, 2024 11:19
Copy link

sentry-io bot commented Mar 6, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NotAllowedError: Failed to execute 'writeText' on 'Clipboard': Document is not focused. copyCode(chunks/app/[[...path]]/src/components/... View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code tab buttons don't work while page is loading
2 participants