Skip to content

fix(dotnet): onboarding install package #14335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2025

Conversation

bruno-garcia
Copy link
Member

No description provided.

Copy link

vercel bot commented Jul 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2025 1:30am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jul 12, 2025 1:30am

@codeowner-assignment codeowner-assignment bot requested a review from a team July 11, 2025 15:55
```

```shell {tabTitle:Paket CLI}
paket add Sentry --version {{@inject packages.version('sentry.dotnet') }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed for simplicity, dotnet is used by 90% of people at this point

cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Jul 11, 2025

Bundle Report

Changes will increase total bundle size by 570 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-client-array-push 9.82MB -6 bytes (-0.0%) ⬇️
sentry-docs-server-cjs 11.91MB 576 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 879.57kB -0.0%
static/chunks/1831-*.js -3 bytes 422.11kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/Qft77QkcuDMXvzfxyXpx-*.js (New) 684 bytes 684 bytes 100.0% 🚀
static/Qft77QkcuDMXvzfxyXpx-*.js (New) 77 bytes 77 bytes 100.0% 🚀
static/vBphDCYqCxc_1ypS2c8Px/_buildManifest.js (Deleted) -684 bytes 0 bytes -100.0% 🗑️
static/vBphDCYqCxc_1ypS2c8Px/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.67MB -0.0%
../instrumentation.js -3 bytes 996.78kB -0.0%
9523.js -3 bytes 972.72kB -0.0%
../app/[[...path]]/page.js.nft.json 195 bytes 704.95kB 0.03%
../app/platform-redirect/page.js.nft.json 195 bytes 704.86kB 0.03%
../app/sitemap.xml/route.js.nft.json 195 bytes 702.83kB 0.03%

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@bruno-garcia
Copy link
Member Author

They no longer include the installation of the base Sentry package.

Sentry.Profiling brings in Sentry so even if it didn't include the base package, it would work. But, it in fact does bring both which is unfortunate because then instead of both commands stacked, its hows the tab control twice:

image

auto-merge was automatically disabled July 12, 2025 01:20

Pull request was closed

@bruno-garcia bruno-garcia reopened this Jul 12, 2025

</Alert>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I get what's going on here. The file name of this mdx file indicates it's for the default docs for dotnet right (nothing to do with profiling). The only place I see this alert in the current live docs is here though:

Presumably that's because of the OnboardingOption optionId="profiling" in the code.

However, in the preview for this PR, I'm still seeing this alert:
image

Copy link
Member

@Flash0ver Flash0ver Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that's similar, yet different <Alert>, isn't it?
From:

<Alert>
Sentry profiling for .NET is available in _Alpha_ on .NET 8.0+ for:
- Windows
- Linux
- macOS
- iOS
- Mac Catalyst
</Alert>

Do we want to remove the Alert from the profiling page too?

Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page renders and looks good.

@bruno-garcia bruno-garcia merged commit d8c6fad into master Jul 22, 2025
20 checks passed
@bruno-garcia bruno-garcia deleted the fix/dotnet-onboarding-install branch July 22, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants