-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(dotnet): onboarding install package #14335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
``` | ||
|
||
```shell {tabTitle:Paket CLI} | ||
paket add Sentry --version {{@inject packages.version('sentry.dotnet') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed for simplicity, dotnet
is used by 90% of people at this point
Bundle ReportChanges will increase total bundle size by 570 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
view changes for bundle: sentry-docs-server-cjsAssets Changed:
|
|
||
</Alert> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I get what's going on here. The file name of this mdx file indicates it's for the default docs for dotnet right (nothing to do with profiling). The only place I see this alert in the current live docs is here though:
Presumably that's because of the OnboardingOption optionId="profiling"
in the code.
However, in the preview for this PR, I'm still seeing this alert:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that's similar, yet different <Alert>
, isn't it?
From:
sentry-docs/docs/platforms/dotnet/common/profiling/index.mdx
Lines 12 to 22 in 80735a5
<Alert> | |
Sentry profiling for .NET is available in _Alpha_ on .NET 8.0+ for: | |
- Windows | |
- Linux | |
- macOS | |
- iOS | |
- Mac Catalyst | |
</Alert> |
Do we want to remove the Alert
from the profiling
page too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Page renders and looks good.
No description provided.