profiling(cocoa): add note about stopping launch profiler #13871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I'm not able to see why vercel failed |
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
philprime
approved these changes
May 30, 2025
| @@ -130,6 +130,10 @@ If configured with trace lifecycle, app start profiles are attached to a special | |||
|
|
|||
| Every time `SentrySDK.startWithOptions` is called with app start profiling configured, a separate sample decision is generated with `sessionSampleRate` and stored until the next app launch (as well as `tracesSampleRate` if trace profile lifecycle is configured). The same sample decision will apply for the remainder of the profile session following that subsequent launch. | |||
|
|
|||
| <Alert> | |||
| If the SDK does not start on the same launch as a launch profiler is running, the profiler will run for the duration of that user session. Ensure proper configuration if you selectively start the Sentry SDK along with launch profiling. | |||
There was a problem hiding this comment.
m: Maybe we should explain here what "proper configuration" means.
coolguyzone
reviewed
Jun 2, 2025
| @@ -130,6 +130,10 @@ If configured with trace lifecycle, app start profiles are attached to a special | |||
|
|
|||
| Every time `SentrySDK.startWithOptions` is called with app start profiling configured, a separate sample decision is generated with `sessionSampleRate` and stored until the next app launch (as well as `tracesSampleRate` if trace profile lifecycle is configured). The same sample decision will apply for the remainder of the profile session following that subsequent launch. | |||
|
|
|||
| <Alert> | |||
| If the SDK does not start on the same launch as a launch profiler is running, the profiler will run for the duration of that user session. Ensure proper configuration if you selectively start the Sentry SDK along with launch profiling. | |||
There was a problem hiding this comment.
If the SDK does not start on the same launch as a launch profiler is running, the profiler will run for the duration of that user session.
I'm having a little bit of trouble parsing this first sentence. Can you clarify a little bit? Would something like "...the same launch as the one where the profiler is running" make sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
As noted here: getsentry/sentry-cocoa#3637 (comment)
We have a limitation where we cannot control what happens to a launch profiler if the SDK is never started after a profiled app launch.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES