-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: Allow to have top level alias for platforms #13069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 467 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-client-array-pushAssets Changed:
Files in
Files in
view changes for bundle: sentry-docs-server-cjsAssets Changed:
Files in
Files in
App Routes Affected:
|
c219e37
to
97bd3f4
Compare
So basically the "top level" JavaScript docs are all about using You cannot and should not look at the top level "JavaScript" docs if you want to e.g. set up a node app, because it is literally Browser specific. Contrary to most other platforms/guides, in the case of JS the platform docs are not really a subset of the guide docs, sadly :/ But today, this is not really clear at all, and you can easily be tempted to look at the JS docs if you want more specific docs for another framework/guide! |
Yeah IMO this is a raelly good point. The reality is, similar to what @mydea already said, in most cases if someone is looking for "top level" JavaScript, they are probably ultimately looking for Node, but we're sending them to Browser JavaScript. IMO this is a good change - its also smentically accurate since the package we're using is Browser JavaScript anyways. Thanks for the thoughtful suggestion here @mydea! |
Ok @mydea , thanks for the context! The code changes look good to me and so does the preview link. Once one of the docs engineers reviews this should be good to merge. |
Today, it is a bit confusing in some cases, but especially JavaScript, that the top level platform is called "JavaScript" (which all guides inherit from), but actually it is just Browser JavaScript.
This adds a new field which, when set for a platform, will lead to a slightly different behavior:
And
Some notes: