feat(platform): preview project name on top of DSN #13041

a-hariti · 2025-03-19T00:09:16Z

also fixes a "copied" feedback z-index issue

also fixes a "copied" feedback z-index issue closes #13015

vercel · 2025-03-19T00:09:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
develop-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 8, 2025 1:46pm
sentry-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 8, 2025 1:46pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
changelog	⬜️ Ignored (Inspect)	Visit Preview		Apr 8, 2025 1:46pm

codecov · 2025-03-19T00:13:05Z

Bundle Report

Changes will increase total bundle size by 2.32kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
sentry-docs-server-cjs	10.57MB	891 bytes (0.01%) ⬆️
sentry-docs-client-array-push	9.43MB	1.43kB (0.02%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`static/chunks/pages/_app-*.js`	25 bytes	868.19kB	0.0%
`static/css/*.css`	14 bytes	18.68kB	0.07%
`static/chunks/3319-*.js`	-3 bytes	393.41kB	-0.0%
`static/chunks/main-*.js`	30 bytes	1.92kB	1.59%
`static/chunks/app/[[...path]]/page-*.js`	1.36kB	76.27kB	1.82%
`static/IuJAU9iph8M6ZTWeTkfS9/_buildManifest.js` (New)	578 bytes	578 bytes	100.0% 🚀
`static/IuJAU9iph8M6ZTWeTkfS9/_ssgManifest.js` (New)	77 bytes	77 bytes	100.0% 🚀
~~`static/tXgJho91JMJ62tj8Ghv3j/_buildManifest.js`~~ (Deleted)	-578 bytes	0 bytes	-100.0% 🗑️
~~`static/tXgJho91JMJ62tj8Ghv3j/_ssgManifest.js`~~ (Deleted)	-77 bytes	0 bytes	-100.0% 🗑️

Files in static/chunks/app/[[...path]]/page-*.js:

./src/components/codeBlock/code-blocks.module.scss → Total Size: 309 bytes
./src/components/codeBlock/index.tsx → Total Size: 7.41kB

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name	Size Change	Total Size	Change (%)
`1729.js`	-3 bytes	1.57MB	-0.0%
`../instrumentation.js`	-3 bytes	904.32kB	-0.0%
`9523.js`	-3 bytes	880.37kB	-0.0%
`../app/[[...path]]/page.js`	900 bytes	535.52kB	0.17%

Files in ../app/[[...path]]/page.js:

./src/components/codeBlock/index.tsx → Total Size: 6.48kB
./src/components/codeBlock/index.tsx → Total Size: 1.3kB
./src/components/codeBlock/code-blocks.module.scss → Total Size: 300 bytes

App Routes Affected:

App Route	Size Change	Total Size	Change (%)
/[[...path]]	900 bytes	3.08MB	0.03%

philprime · 2025-03-19T08:26:40Z

@a-hariti Thanks for the quick implementation!

How should we deal with the project preview overlaying code?
I don't think there is any good solution because the preview will most likely always be in the way.

One idea that popped to my mind would be reducing the opacity when the cursor is on top of the preview, so that it is possible to view what's below the code, but not sure about that.

https://sentry-docs-git-dsn-preview.sentry.dev/platforms/apple/guides/ios/

a-hariti · 2025-03-20T00:58:26Z

The ideal solution might be to track the user's gaze with AI and move the popup out of their eyesight 😂

a-hariti · 2025-03-20T01:45:21Z

I came up with this hack to add some margin to lines with clickable "keywords", it doesn't discriminate between DSN's or other things, but the worst case scenario is having an apparent extra line of whitespace, so it should do @philprime

philprime

Found a typo, added suggestions.

As my background is more mobile UI than web UI development, it would be great if @chargome could do a proper review on the implementation.

src/components/codeKeywords/styles.css.ts

src/components/codeKeywords/keywordSelector.tsx

chargome · 2025-03-24T09:48:19Z

I think we shuold only show this for dsn, not for orgs and projects:

also rename styles file to be an actual TS file with the confusing .css.ts extention

philprime · 2025-04-04T07:47:41Z

@a-hariti Am I missing something or is the preview for DSNs not in there anymore?

a-hariti · 2025-04-04T14:42:06Z

You didn't miss anything @philprime, I messed up 🫣

please take another look :)

philprime

Code looks fine but it does not seem to pick up all usage cases:

https://sentry-docs-git-dsn-preview.sentry.dev/platforms/javascript/guides/node/

https://sentry-docs-git-dsn-preview.sentry.dev/platforms/apple/guides/ios/

https://sentry-docs-git-dsn-preview.sentry.dev/platforms/dart/guides/flutter/

philprime

Can we make the tooltip not to be picked up from selection?

I selected the text to copy it (instead of using the copy button) and it copied like this:

@import Sentry;
(BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions {
    [SentrySDK startWithConfigureOptions:^(SentryOptions *options) {
        options.dsn = @"https://[email protected]/0example-org / example-project";
        options.debug = YES; // Enabled debug when first installing is always helpful
        // Adds IP for users.
        // For more information, visit: https://docs.sentry.io/platforms/apple/data-management/data-collected/
        options.sendDefaultPii = YES
    }];
    return YES;
}

It seems to append the example-org / example-project to the DSN, while visually it is not selected.

This will cause UX issues with users who prefer to select code to copy it.

…ck copy or / Cmd+C

a-hariti · 2025-04-08T13:56:21Z

Good catch @philprime, it required some gymnastics, but I believe it's good to go now :)

chargome

@a-hariti could we only display this when the user is logged in? Not really useful when the example project is shown I think 🤔

sfanahata · 2025-06-05T18:53:15Z

@a-hariti - what's the status of this one?

feat(platform): preview project name on top of DSN

b763840

also fixes a "copied" feedback z-index issue closes #13015

a-hariti requested review from chargome, philprime and jas-kas March 19, 2025 00:09

vercel bot had a problem deploying to Preview – sentry-docs March 19, 2025 00:12 Failure

vercel bot had a problem deploying to Preview – develop-docs March 19, 2025 00:13 Failure

remove unused import

afe7fa7

vercel bot deployed to Preview – develop-docs March 19, 2025 01:01 View deployment

vercel bot deployed to Preview – sentry-docs March 19, 2025 01:11 View deployment

fix project name preview overlap

7ed48e6

vercel bot deployed to Preview – sentry-docs March 20, 2025 01:43 View deployment

vercel bot deployed to Preview – develop-docs March 20, 2025 01:48 View deployment

a-hariti enabled auto-merge (squash) March 20, 2025 02:05

philprime reviewed Mar 24, 2025

View reviewed changes

src/components/codeKeywords/styles.css.ts Outdated Show resolved Hide resolved

src/components/codeKeywords/keywordSelector.tsx Outdated Show resolved Hide resolved

src/components/codeKeywords/keywordSelector.tsx Outdated Show resolved Hide resolved

a-hariti and others added 3 commits April 3, 2025 13:22

fix typo

902e76b

show preview on project slug keyword only

e9efe46

also rename styles file to be an actual TS file with the confusing .css.ts extention

[getsentry/action-github-commit] Auto commit

550d07e

vercel bot deployed to Preview – develop-docs April 3, 2025 14:34 View deployment

a-hariti requested a review from philprime April 3, 2025 14:47

vercel bot deployed to Preview – sentry-docs April 3, 2025 14:51 View deployment

fix preview keyword

8117824

vercel bot deployed to Preview – develop-docs April 4, 2025 14:20 View deployment

vercel bot deployed to Preview – sentry-docs April 4, 2025 14:30 View deployment

philprime reviewed Apr 7, 2025

View reviewed changes

relax DSN keyword regex

bf09870

a-hariti requested a review from philprime April 7, 2025 12:34

vercel bot deployed to Preview – develop-docs April 7, 2025 12:38 View deployment

vercel bot deployed to Preview – sentry-docs April 7, 2025 12:47 View deployment

philprime reviewed Apr 8, 2025

View reviewed changes

prevent .no-copy elements from being copied during selction Right cli…

1a27ff5

…ck copy or / Cmd+C

vercel bot deployed to Preview – develop-docs April 8, 2025 13:37 View deployment

vercel bot deployed to Preview – sentry-docs April 8, 2025 13:46 View deployment

a-hariti requested a review from philprime April 8, 2025 13:56

chargome reviewed Apr 24, 2025

View reviewed changes

philprime removed their request for review June 23, 2025 09:19

Uh oh!

feat(platform): preview project name on top of DSN #13041

Are you sure you want to change the base?

feat(platform): preview project name on top of DSN #13041

Uh oh!

Conversation

a-hariti commented Mar 19, 2025

Uh oh!

vercel bot commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Affected Assets, Files, and Routes:

Assets Changed:

Assets Changed:

App Routes Affected:

Uh oh!

philprime commented Mar 19, 2025

Uh oh!

a-hariti commented Mar 20, 2025

Uh oh!

a-hariti commented Mar 20, 2025

Uh oh!

philprime left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chargome commented Mar 24, 2025

Uh oh!

philprime commented Apr 4, 2025

Uh oh!

a-hariti commented Apr 4, 2025

Uh oh!

philprime left a comment

Choose a reason for hiding this comment

Uh oh!

philprime left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

a-hariti commented Apr 8, 2025

Uh oh!

chargome left a comment

Choose a reason for hiding this comment

Uh oh!

sfanahata commented Jun 5, 2025

Uh oh!

Uh oh!

vercel bot commented Mar 19, 2025 •

edited

Loading

codecov bot commented Mar 19, 2025 •

edited

Loading

philprime left a comment •

edited

Loading