Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(platform): preview project name on top of DSN #13041

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

a-hariti
Copy link
Collaborator

also fixes a "copied" feedback z-index issue

closes #13015

also fixes a "copied" feedback z-index issue

closes #13015
Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 2:03am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2025 2:03am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2025 2:03am

Copy link

codecov bot commented Mar 19, 2025

Bundle Report

Changes will increase total bundle size by 1.5kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.57MB 672 bytes (0.01%) ⬆️
sentry-docs-client-array-push 9.43MB 824 bytes (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.16kB -0.0%
static/css/*.css 14 bytes 18.68kB 0.07%
static/chunks/3319-*.js -3 bytes 393.41kB -0.0%
static/chunks/app/[[...path]]/page-*.js 816 bytes 75.72kB 1.09%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/XsPVA1Y8ioKzhhVI87sMf/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/XsPVA1Y8ioKzhhVI87sMf/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/tXgJho91JMJ62tj8Ghv3j/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/tXgJho91JMJ62tj8Ghv3j/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Files in static/chunks/app/[[...path]]/page-*.js:

  • ./src/components/codeBlock/code-blocks.module.scss → Total Size: 309 bytes

  • ./src/components/codeBlock/index.tsx → Total Size: 6.54kB

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.57MB -0.0%
../instrumentation.js -3 bytes 904.32kB -0.0%
9523.js -3 bytes 880.37kB -0.0%
../app/[[...path]]/page.js 681 bytes 535.3kB 0.13%

Files in ../app/[[...path]]/page.js:

  • ./src/components/codeBlock/index.tsx → Total Size: 1.3kB

  • ./src/components/codeBlock/index.tsx → Total Size: 5.85kB

  • ./src/components/codeBlock/code-blocks.module.scss → Total Size: 300 bytes

App Routes Affected:

App Route Size Change Total Size Change (%)
/[[...path]] 681 bytes 3.08MB 0.02%

@philprime
Copy link
Contributor

@a-hariti Thanks for the quick implementation!

How should we deal with the project preview overlaying code?
I don't think there is any good solution because the preview will most likely always be in the way.

One idea that popped to my mind would be reducing the opacity when the cursor is on top of the preview, so that it is possible to view what's below the code, but not sure about that.

https://sentry-docs-git-dsn-preview.sentry.dev/platforms/apple/guides/ios/

image image

@a-hariti
Copy link
Collaborator Author

The ideal solution might be to track the user's gaze with AI and move the popup out of their eyesight 😂

@a-hariti
Copy link
Collaborator Author

I came up with this hack to add some margin to lines with clickable "keywords", it doesn't discriminate between DSN's or other things, but the worst case scenario is having an apparent extra line of whitespace, so it should do @philprime

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add preview for org / project name for DSN
2 participants