Skip to content

chore: fix analyze in Dart and Hive #3174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 20, 2025
Merged

chore: fix analyze in Dart and Hive #3174

merged 8 commits into from
Aug 20, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Aug 14, 2025

  • Fixes analyze errors in Dart and Hive
  • Marks SentryIOOverrides as final (beta analyzer issue)

#skip-changelog

Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.67%. Comparing base (c1e775e) to head (7ed811a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3174      +/-   ##
==========================================
- Coverage   87.79%   87.67%   -0.13%     
==========================================
  Files         291      291              
  Lines        9907     9907              
==========================================
- Hits         8698     8686      -12     
- Misses       1209     1221      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor changed the title chore: fix analyze chore: fix analyze in Dart and Hive Aug 14, 2025
Copy link
Contributor

github-actions bot commented Aug 14, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 473.02 ms 481.39 ms 8.37 ms
Size 6.54 MiB 7.70 MiB 1.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
0929dbf 462.82 ms 492.76 ms 29.94 ms
2cb90b9 479.38 ms 552.69 ms 73.31 ms
de377fd 572.35 ms 589.21 ms 16.87 ms
6f47800 451.04 ms 509.64 ms 58.60 ms
79f6b41 469.66 ms 525.90 ms 56.24 ms
7cfbbd6 499.69 ms 592.24 ms 92.55 ms
2d34233 470.54 ms 558.90 ms 88.36 ms
f761369 462.73 ms 563.80 ms 101.06 ms
73a3c38 478.18 ms 526.62 ms 48.44 ms
81f83eb 471.40 ms 522.14 ms 50.74 ms

App size

Revision Plain With Sentry Diff
0929dbf 6.54 MiB 7.70 MiB 1.17 MiB
2cb90b9 6.54 MiB 7.70 MiB 1.17 MiB
de377fd 6.54 MiB 7.71 MiB 1.17 MiB
6f47800 6.54 MiB 7.69 MiB 1.15 MiB
79f6b41 6.54 MiB 7.69 MiB 1.15 MiB
7cfbbd6 6.54 MiB 7.70 MiB 1.17 MiB
2d34233 6.54 MiB 7.55 MiB 1.01 MiB
f761369 6.54 MiB 7.70 MiB 1.16 MiB
73a3c38 6.54 MiB 7.69 MiB 1.15 MiB
81f83eb 6.54 MiB 7.69 MiB 1.15 MiB

Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1265.82 ms 1276.47 ms 10.65 ms
Size 20.70 MiB 22.46 MiB 1.75 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2cb90b9 1272.90 ms 1285.55 ms 12.66 ms
dbd526b 1244.78 ms 1259.02 ms 14.24 ms
81f83eb 1259.53 ms 1273.39 ms 13.86 ms
793f4dc 1262.50 ms 1282.35 ms 19.85 ms
93b7728 1247.23 ms 1264.87 ms 17.64 ms
6ba4675 1223.12 ms 1238.17 ms 15.04 ms
4481076 1256.48 ms 1266.64 ms 10.17 ms
cc4e375 1253.06 ms 1263.81 ms 10.75 ms
73dca78 1246.65 ms 1265.42 ms 18.76 ms
ec78888 1251.37 ms 1269.40 ms 18.04 ms

App size

Revision Plain With Sentry Diff
2cb90b9 7.86 MiB 9.54 MiB 1.69 MiB
dbd526b 7.86 MiB 9.44 MiB 1.58 MiB
81f83eb 7.86 MiB 9.44 MiB 1.58 MiB
793f4dc 7.86 MiB 9.44 MiB 1.58 MiB
93b7728 7.86 MiB 9.44 MiB 1.58 MiB
6ba4675 7.86 MiB 9.44 MiB 1.58 MiB
4481076 7.86 MiB 9.44 MiB 1.58 MiB
cc4e375 7.86 MiB 9.44 MiB 1.58 MiB
73dca78 7.86 MiB 9.44 MiB 1.58 MiB
ec78888 7.86 MiB 9.44 MiB 1.58 MiB

@denrase denrase merged commit 54acf91 into main Aug 20, 2025
172 of 173 checks passed
@denrase denrase deleted the chore/fix-analyze branch August 20, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants