Skip to content

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Aug 13, 2025

#skip-changelog

Fix working directory for diagrams.yml

@denrase denrase marked this pull request as ready for review August 13, 2025 09:32
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah thx, was an oversight

@denrase
Copy link
Collaborator Author

denrase commented Aug 13, 2025

Also ran the diagrams workflow once here.

Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.67%. Comparing base (54acf91) to head (b86733c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3169      +/-   ##
==========================================
- Coverage   87.79%   87.67%   -0.13%     
==========================================
  Files         291      291              
  Lines        9907     9907              
==========================================
- Hits         8698     8686      -12     
- Misses       1209     1221      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor
Copy link
Contributor

huh where do those CI fails come from

@denrase
Copy link
Collaborator Author

denrase commented Aug 13, 2025

huh, was there a flutter stable release?

Copy link
Contributor

github-actions bot commented Aug 20, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1258.24 ms 1270.84 ms 12.59 ms
Size 20.70 MiB 22.46 MiB 1.75 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b6c8720 1252.65 ms 1266.61 ms 13.96 ms
575ebaa 1262.20 ms 1274.24 ms 12.04 ms
640ad0c 1241.04 ms 1253.96 ms 12.92 ms
93b7728 1247.23 ms 1264.87 ms 17.64 ms
793f4dc 1262.50 ms 1282.35 ms 19.85 ms
32914d8 1275.47 ms 1285.20 ms 9.73 ms
eca355d 1238.39 ms 1266.98 ms 28.59 ms
2d34233 1258.19 ms 1268.92 ms 10.73 ms
6b69699 1254.80 ms 1273.31 ms 18.52 ms
73dca78 1246.65 ms 1265.42 ms 18.76 ms

App size

Revision Plain With Sentry Diff
b6c8720 7.86 MiB 9.44 MiB 1.58 MiB
575ebaa 7.86 MiB 9.44 MiB 1.58 MiB
640ad0c 7.86 MiB 9.44 MiB 1.58 MiB
93b7728 7.86 MiB 9.44 MiB 1.58 MiB
793f4dc 7.86 MiB 9.44 MiB 1.58 MiB
32914d8 7.86 MiB 9.44 MiB 1.58 MiB
eca355d 7.86 MiB 9.44 MiB 1.58 MiB
2d34233 7.86 MiB 9.44 MiB 1.58 MiB
6b69699 7.86 MiB 9.44 MiB 1.58 MiB
73dca78 7.86 MiB 9.44 MiB 1.58 MiB

Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 442.10 ms 498.92 ms 56.82 ms
Size 6.54 MiB 7.70 MiB 1.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4481076 484.08 ms 505.70 ms 21.61 ms
6f47800 451.04 ms 509.64 ms 58.60 ms
f761369 462.73 ms 563.80 ms 101.06 ms
93b7728 475.28 ms 489.13 ms 13.86 ms
79f6b41 469.66 ms 525.90 ms 56.24 ms
81f83eb 471.40 ms 522.14 ms 50.74 ms
765aa8b 493.51 ms 531.23 ms 37.72 ms
e2d675d 457.92 ms 529.17 ms 71.25 ms
eca355d 485.50 ms 569.85 ms 84.35 ms
e45c0e1 447.29 ms 558.33 ms 111.04 ms

App size

Revision Plain With Sentry Diff
4481076 6.54 MiB 7.69 MiB 1.15 MiB
6f47800 6.54 MiB 7.69 MiB 1.15 MiB
f761369 6.54 MiB 7.70 MiB 1.16 MiB
93b7728 6.54 MiB 7.69 MiB 1.15 MiB
79f6b41 6.54 MiB 7.69 MiB 1.15 MiB
81f83eb 6.54 MiB 7.69 MiB 1.15 MiB
765aa8b 6.54 MiB 7.70 MiB 1.16 MiB
e2d675d 6.54 MiB 7.69 MiB 1.15 MiB
eca355d 6.54 MiB 7.70 MiB 1.16 MiB
e45c0e1 6.54 MiB 7.70 MiB 1.16 MiB

@denrase denrase merged commit 7cfee3b into main Aug 21, 2025
163 checks passed
@denrase denrase deleted the fix/diagrams-path branch August 21, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants