Skip to content

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jun 3, 2025

📜 Description

  • Mask RichText

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.23%. Comparing base (cd41125) to head (cbc674a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2975      +/-   ##
==========================================
+ Coverage   87.62%   89.23%   +1.60%     
==========================================
  Files         278       93     -185     
  Lines        9175     3085    -6090     
==========================================
- Hits         8040     2753    -5287     
+ Misses       1135      332     -803     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Jun 3, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 508.17 ms 585.52 ms 77.35 ms
Size 6.54 MiB 7.53 MiB 1014.46 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
379d7a8 327.10 ms 355.39 ms 28.29 ms
c70e01a 331.04 ms 401.46 ms 70.42 ms
213fb39 509.17 ms 557.36 ms 48.20 ms
3392f27 486.67 ms 629.35 ms 142.68 ms
04bd9e6 402.06 ms 483.56 ms 81.50 ms
1c926c2 424.57 ms 493.89 ms 69.32 ms
31b2afb 397.04 ms 475.09 ms 78.04 ms
7c7c64f 442.35 ms 492.79 ms 50.44 ms
f79eecf 341.35 ms 388.98 ms 47.63 ms
4829ad3 381.55 ms 455.45 ms 73.90 ms

App size

Revision Plain With Sentry Diff
379d7a8 5.94 MiB 6.95 MiB 1.01 MiB
c70e01a 5.94 MiB 6.97 MiB 1.03 MiB
213fb39 6.44 MiB 7.43 MiB 1010.28 KiB
3392f27 6.46 MiB 7.48 MiB 1.02 MiB
04bd9e6 6.35 MiB 7.34 MiB 1008.33 KiB
1c926c2 6.46 MiB 7.48 MiB 1.03 MiB
31b2afb 6.34 MiB 7.28 MiB 966.36 KiB
7c7c64f 6.49 MiB 7.57 MiB 1.08 MiB
f79eecf 6.15 MiB 7.13 MiB 1000.07 KiB
4829ad3 6.33 MiB 7.26 MiB 943.11 KiB

Previous results on branch: enha/improve-masking

Startup times

Revision Plain With Sentry Diff
21320f4 466.51 ms 554.49 ms 87.98 ms
9f5c5c4 416.69 ms 433.22 ms 16.53 ms
f708f04 467.49 ms 563.81 ms 96.32 ms

App size

Revision Plain With Sentry Diff
21320f4 6.44 MiB 7.44 MiB 1017.54 KiB
9f5c5c4 6.44 MiB 7.44 MiB 1017.54 KiB
f708f04 6.54 MiB 7.53 MiB 1014.46 KiB

Copy link
Contributor

github-actions bot commented Jun 3, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1251.90 ms 1269.33 ms 17.44 ms
Size 7.85 MiB 9.42 MiB 1.57 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
bf8d36c 1238.33 ms 1258.71 ms 20.38 ms
136c365 1248.12 ms 1277.33 ms 29.20 ms
3f3ef0b 1223.73 ms 1237.67 ms 13.94 ms
dfbe468 1250.73 ms 1275.61 ms 24.88 ms
ef6466d 1209.88 ms 1225.81 ms 15.93 ms
30c1193 1227.20 ms 1235.00 ms 7.80 ms
6ec7b50 1239.61 ms 1268.93 ms 29.32 ms
3e4b523 1260.53 ms 1270.06 ms 9.53 ms
21d4150 1252.86 ms 1280.55 ms 27.69 ms
6f3717a 1259.84 ms 1280.90 ms 21.06 ms

App size

Revision Plain With Sentry Diff
bf8d36c 8.38 MiB 9.74 MiB 1.36 MiB
136c365 8.38 MiB 9.75 MiB 1.37 MiB
3f3ef0b 8.32 MiB 9.38 MiB 1.05 MiB
dfbe468 8.43 MiB 10.01 MiB 1.58 MiB
ef6466d 8.33 MiB 9.40 MiB 1.07 MiB
30c1193 8.28 MiB 9.34 MiB 1.06 MiB
6ec7b50 8.38 MiB 9.75 MiB 1.37 MiB
3e4b523 8.28 MiB 9.33 MiB 1.05 MiB
21d4150 8.16 MiB 9.17 MiB 1.01 MiB
6f3717a 8.33 MiB 9.62 MiB 1.29 MiB

Previous results on branch: enha/improve-masking

Startup times

Revision Plain With Sentry Diff
21320f4 1259.06 ms 1276.56 ms 17.49 ms
f708f04 1244.12 ms 1254.71 ms 10.59 ms
9f5c5c4 1252.12 ms 1269.23 ms 17.11 ms

App size

Revision Plain With Sentry Diff
21320f4 8.43 MiB 10.00 MiB 1.56 MiB
f708f04 7.85 MiB 9.42 MiB 1.57 MiB
9f5c5c4 8.43 MiB 10.00 MiB 1.56 MiB

@denrase denrase changed the title Imorove Masking Replay: Mask RichText Jun 3, 2025
@denrase denrase changed the title Replay: Mask RichText Replay: Mask RichText Widgets Jun 3, 2025
@denrase denrase marked this pull request as ready for review June 3, 2025 14:04
@buenaflor
Copy link
Contributor

I'll fix the tests

@buenaflor buenaflor merged commit f934650 into main Jun 10, 2025
70 of 72 checks passed
@buenaflor buenaflor deleted the enha/improve-masking branch June 10, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants